From a8f18f3f70b0ba4f1352f61f9ae5ce674a3254c0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 14 Apr 2024 03:04:53 +0000 Subject: [PATCH 1/3] Bump SonarAnalyzer.CSharp in /src in the analyzers group Bumps the analyzers group in /src with 1 update: [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet). Updates `SonarAnalyzer.CSharp` from 9.23.1.88495 to 9.23.2.88755 - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](https://github.com/SonarSource/sonar-dotnet/compare/9.23.1.88495...9.23.2.88755) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-patch dependency-group: analyzers ... Signed-off-by: dependabot[bot] --- .../Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.AutoMoq.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.Core.Tests.csproj | 2 +- .../Objectivity.AutoFixture.XUnit2.Core.csproj | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj index 2ca3eccd..8358ea44 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj @@ -76,7 +76,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj index b95ed367..17e27918 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy/Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj @@ -101,7 +101,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj index 90a6f3a4..aea3e9f2 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests/Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj @@ -77,7 +77,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoMoq/Objectivity.AutoFixture.XUnit2.AutoMoq.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoMoq/Objectivity.AutoFixture.XUnit2.AutoMoq.csproj index d34f3a04..c3634f84 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoMoq/Objectivity.AutoFixture.XUnit2.AutoMoq.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoMoq/Objectivity.AutoFixture.XUnit2.AutoMoq.csproj @@ -101,7 +101,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj index fea241fc..c96b9997 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj @@ -76,7 +76,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj b/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj index 21c90a05..7095d988 100644 --- a/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.AutoNSubstitute/Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj @@ -101,7 +101,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Objectivity.AutoFixture.XUnit2.Core.Tests.csproj b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Objectivity.AutoFixture.XUnit2.Core.Tests.csproj index 11f01e60..266072c4 100644 --- a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Objectivity.AutoFixture.XUnit2.Core.Tests.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Objectivity.AutoFixture.XUnit2.Core.Tests.csproj @@ -75,7 +75,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Objectivity.AutoFixture.XUnit2.Core/Objectivity.AutoFixture.XUnit2.Core.csproj b/src/Objectivity.AutoFixture.XUnit2.Core/Objectivity.AutoFixture.XUnit2.Core.csproj index aab2a474..4dfe07a4 100644 --- a/src/Objectivity.AutoFixture.XUnit2.Core/Objectivity.AutoFixture.XUnit2.Core.csproj +++ b/src/Objectivity.AutoFixture.XUnit2.Core/Objectivity.AutoFixture.XUnit2.Core.csproj @@ -82,7 +82,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive From 1d58c7728fa2d1c5dbfbb6164e60aefec90811f2 Mon Sep 17 00:00:00 2001 From: Piotr Zajac Date: Mon, 15 Apr 2024 17:00:39 +0200 Subject: [PATCH 2/3] Update xUnit rules --- src/.editorconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/.editorconfig b/src/.editorconfig index c0ab7a55..0c9263aa 100644 --- a/src/.editorconfig +++ b/src/.editorconfig @@ -3560,6 +3560,18 @@ dotnet_diagnostic.xUnit1042.severity = suggestion # xUnit1043: Constructors on classes derived from FactAttribute must be public when used on test methods dotnet_diagnostic.xUnit1043.severity = error +# xUnit1044: Avoid using TheoryData type arguments that are not serializable +dotnet_diagnostic.xUnit1044.severity = none + +# xUnit1045: Avoid using TheoryData type arguments that might not be serializable +dotnet_diagnostic.xUnit1045.severity = none + +# xUnit1046: Avoid using TheoryDataRow arguments that are not serializable +dotnet_diagnostic.xUnit1046.severity = none + +# xUnit1047: Avoid using TheoryDataRow arguments that might not be serializable +dotnet_diagnostic.xUnit1047.severity = none + # xUnit2000: Constants and literals should be the expected argument dotnet_diagnostic.xUnit2000.severity = warning From db8e877c720881d01eb0d8dbf68d2240fe6c0478 Mon Sep 17 00:00:00 2001 From: Piotr Zajac Date: Mon, 15 Apr 2024 17:01:24 +0200 Subject: [PATCH 3/3] Use generics instead of objects --- .../Attributes/ExceptAttributeTests.cs | 10 +++++----- .../Attributes/PickFromValuesAttributeTests.cs | 6 +++--- .../Factories/NegativeValuesRequestFactoryTests.cs | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/ExceptAttributeTests.cs b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/ExceptAttributeTests.cs index 05c3b07c..57eb4a14 100644 --- a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/ExceptAttributeTests.cs +++ b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/ExceptAttributeTests.cs @@ -86,9 +86,9 @@ public void GivenUninitializedArgument_WhenGetCustomizationIsInvoked_ThenExcepti [InlineData(1, 1)] [InlineData("a", "a")] [Theory(DisplayName = "GIVEN identical arguments WHEN constructor is invoked THEN unique parameters are properly assigned")] - public void GivenIdenticalArguments_WhenConstructorIsInvoked_ThenUniqueParametersAreProperlyAssigned( - object first, - object second) + public void GivenIdenticalArguments_WhenConstructorIsInvoked_ThenUniqueParametersAreProperlyAssigned( + T first, + T second) { // Arrange var attribute = new ExceptAttribute(first, second); @@ -114,8 +114,8 @@ public void GivenIncomparableArgument_WhenConstructorIsInvoked_ThenParametersAre [MemberData(nameof(CustomizationUsageTestData))] [Theory(DisplayName = "GIVEN valid parameters WHEN customization is used THEN expected values are generated")] - public void GivenValidParameters_WhenCustomizationIsUsed_ThenExpectedValuesAreGenerated( - object item) + public void GivenValidParameters_WhenCustomizationIsUsed_ThenExpectedValuesAreGenerated( + T item) { // Arrange var attribute = new ExceptAttribute(item); diff --git a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/PickFromValuesAttributeTests.cs b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/PickFromValuesAttributeTests.cs index fc74c6fb..3bb56422 100644 --- a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/PickFromValuesAttributeTests.cs +++ b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Attributes/PickFromValuesAttributeTests.cs @@ -93,9 +93,9 @@ public void GivenNoArguments_WhenConstructorIsInvoked_ThenExceptionIsThrown() [InlineData(1, 1)] [InlineData("a", "a")] [Theory(DisplayName = "GIVEN identical arguments WHEN constructor is invoked THEN unique parameters are properly assigned")] - public void GivenIdenticalArguments_WhenConstructorIsInvoked_ThenUniqueParametersAreProperlyAssigned( - object first, - object second) + public void GivenIdenticalArguments_WhenConstructorIsInvoked_ThenUniqueParametersAreProperlyAssigned( + T first, + T second) { // Arrange var attribute = new PickFromValuesAttribute(first, second); diff --git a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Factories/NegativeValuesRequestFactoryTests.cs b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Factories/NegativeValuesRequestFactoryTests.cs index 61766d41..e892e474 100644 --- a/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Factories/NegativeValuesRequestFactoryTests.cs +++ b/src/Objectivity.AutoFixture.XUnit2.Core.Tests/Factories/NegativeValuesRequestFactoryTests.cs @@ -111,10 +111,10 @@ public void GivenSupportedEnumType_WhenCreateIsInvoked_ThenReturnsRequestWithNeg [MemberData(nameof(NumericTypeUsageTestData))] [Theory(DisplayName = "GIVEN supported numeric type WHEN Create is invoked THEN returns request with expected range")] - public void GivenSupportedNumericType_WhenCreateIsInvoked_ThenReturnsRequestWithExpectedRange( + public void GivenSupportedNumericType_WhenCreateIsInvoked_ThenReturnsRequestWithExpectedRange( Type type, - object min, - object max) + T min, + T max) { // Arrange // Act