Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Deploy job should by default publish data to Environment dashboard #10

Open
deors opened this issue Apr 15, 2016 · 5 comments

Comments

@deors
Copy link

deors commented Apr 15, 2016

Deploy job should by default publish data to Environment dashboard. Currently it is not done. Investigate if this is a limitation of the DSL, and if not, enable the action with these settings:

Environment name = ${ENVIRONMENT_NAME}
Component name = Pet Clinic
Build number = ${B}
Build job = ${BUILD_NAME}

@anton-kasperovich
Copy link
Contributor

@deors why do we need Component name as static value? We can make it dynamic, via ${PROJECT_NAME} . I think we should cover all 3 deploy. I will take care of this one.

@deors
Copy link
Author

deors commented Apr 22, 2016

+1 for both suggestions. Re project name I didn't suggest because in this
case it would show as ExampleProject, but using the env var seems like the
logical way of doing it. If it shows as example project in dashboard will
not harm as it is the example project. Thanks!

El vie., 22 abr. 2016 10:26, Anton Kasperovich [email protected]
escribió:

@deors https://github.com/deors why do we need Component name as static
value? We can make it dynamic, via ${PROJECT_NAME} . I think we should
cover all 3 deploy. I will take care of this one.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

@nickdgriffin
Copy link
Contributor

I don't think the environment dashboard plugin is really fit for purpose at the moment. It doesn't account for the fact we have multiple workspaces and the dashboard contents is global wherever the view is created. If a column is an environment and a row is a component/project, there's nowhere to represent the workspace without it going in with the component/project name - and that means the table is going to get quite bloated if there are lots of workspaces or lots of differently named environments.

@anton-kasperovich
Copy link
Contributor

@deors i implemented this in DSL, but after discussion with Nick looks like it can't be accepted on "ADOP Core level", if you still need it, feel free to copy source code from my external branch anton-kasperovich@c2540fa

@deors
Copy link
Author

deors commented Apr 22, 2016

Ok, understood. Let's leave it as is for now until we can find a more elegant way of presenting the information, probably as suggested by enhancing the environment dashboard so it can be either local, or workspace aware.
Are you fine if we leave this open for now, so we don't completely forget about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants