✨ Add pipeline for publishing to marketplace #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvfch
force-pushed
the
feat/add-vscode-marketplace-pipeline
branch
from
2d74684 to
69d0993
Compare
pavelsvagr
reviewed
Dec 20, 2024
package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "contributes": {}, | |||
| "scripts": { | |||
| "vscode:prepublish": "npm run compile", | |||
| "vscode:publish": "vsce publish", | |||
There was a problem hiding this comment.
How the vsce gets into remote ubuntu/latest environment? Is the tool included in actions/setup-node@v4?
There was a problem hiding this comment.
Yes, you're right. What would be better in your opinion:
- Add vsce dependency to package.json
- Globally install vsce and publish in gh workflow and remove this line at all?
There was a problem hiding this comment.
I would install vsce in workflow only.
Please, use some predefined action for that e.g. github-action-for-vsce
rvfch
force-pushed
the
feat/add-vscode-marketplace-pipeline
branch
from
69d0993 to
dd8c4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCE_TOKEN(marketplace API key) environment variable in the repository settings.Ref #2