new v1.29 is still looking for MAT_Places512_G_fp16 inside the old Comfy models/inpaint folder

[valery016]

After installing the new v1.29, I spent half an hour resolving the red-colored error message showing up during plugin's startup about missing mat_places512_g_fp16 file. I put a copy of the file everywhere I could think of in both managed and external trees (about 6 copies in total), the plugin still wouldn't find it. It's only after I placed it inside the old Comfy/models tree of the managed server (in the inpaint subfolder) that it could start without an error. It's also strange because I was trying to start the plugin using an external Comfy server, not the managed one.

[valery016]

After posting the above I found that the same thing applies to the inpaint fooocus models for SDXL and some other model files.

[Acly]

Relevant information:

• the update log (should be part of client.log)
• what exactly is in [server-path]/models/inpaint vs [server-path]/ComfyUI/models/inpaint
• contents of [server-path]/ComfyUI/extra_model_paths.yaml

Not really sure about the mixup between managed/custom install, only way that's possible is if the extra_model_paths.yaml is somehow pointing to the other install on your system.

[valery016]

Ok, here goes. The update log section:

v1.29.install.log

[server-path]/models/inpaint]

C:\AI\ai_diffusion.serverI\models\inpaint>dir
Volume in drive C is System
Volume Serial Number is 2286-4F9D

Directory of C:\AI\ai_diffusion.serverI\models\inpaint

06/12/2024 20:37

.
19/10/2024 12:14 ..
13/02/2024 17:29 998 config.json
13/02/2024 18:32 1.445.157.124 diffusion_pytorch_inpaint.safetensors
13/02/2024 15:53 52.602 fooocus_inpaint_head.pth
29/06/2024 22:48 102.218.542 fooocus_lama.safetensors
13/02/2024 15:55 1.323.362.033 inpaint_v26.fooocus.patch
29/06/2024 21:08 2.502.139.104 Kataragi_inpaintXL-fp16.safetensors
13/02/2024 15:50 125.280.278 mat_places512_g_fp16.safetensors
13/07/2024 20:13 32.768 model_metadata.ldb
8 File(s) 5.498.243.449 bytes
2 Dir(s) 498.850.418.688 bytes free

[server-path]/ComfyUI/models/inpaint]

C:\AI\ai_diffusion.serverI\ComfyUI\models\inpaint>dir
Volume in drive C is System
Volume Serial Number is 2286-4F9D

Directory of C:\AI\ai_diffusion.serverI\ComfyUI\models\inpaint

06/12/2024 20:37

.
07/12/2024 00:33 ..
13/02/2024 17:29 998 config.json
13/02/2024 18:32 1.445.157.124 diffusion_pytorch_inpaint.safetensors
29/06/2024 22:48 52.602 fooocus_inpaint_head.pth
29/06/2024 22:48 102.218.542 fooocus_lama.safetensors
29/06/2024 22:45 1.323.362.033 inpaint_v26.fooocus.patch
29/06/2024 21:08 2.502.139.104 Kataragi_inpaintXL-fp16.safetensors
13/02/2024 15:50 125.280.278 mat_places512_g_fp16.safetensors
13/07/2024 20:13 32.768 model_metadata.ldb
8 File(s) 5.498.243.449 bytes
2 Dir(s) 498.858.962.944 bytes free

[server-path]/ComfyUI/extra_model_paths.yaml (renamed to extra_model_paths.yaml.txt just to be able to drop it here]

extra_model_paths.yaml.txt

[valery016]

Also on this subject: I could never get the plugin use the clip_l model in my config, it is always listed as not found in the client.log, no matter where I place it (it is now in about 6 locations, including those under Stability Matrix, still the same):

C:\AI\ai_diffusion.serverI\models\clip_vision>dir /s
Volume in drive C is System
Volume Serial Number is 2286-4F9D

Directory of C:\AI\ai_diffusion.serverI\models\clip_vision

06/12/2024 21:36

.
19/10/2024 12:14 ..
06/12/2024 21:30 246.144.152 clip_l.safetensors
17/10/2024 18:18 3.689.911.098 clip_vision_g.safetensors
13/02/2024 15:40 0 put_clip_vision_models_here
18/10/2024 22:18 SD1.5
3 File(s) 3.936.055.250 bytes

Directory of C:\AI\ai_diffusion.serverI\models\clip_vision\SD1.5

18/10/2024 22:18

.
06/12/2024 21:36 ..
13/02/2024 15:50 2.528.373.448 model.safetensors
1 File(s) 2.528.373.448 bytes

 Total Files Listed:
           4 File(s)  6.464.428.698 bytes
           5 Dir(s)  498.844.303.360 bytes free

The last occurrence:

2024-12-07 00:30:37,687 INFO Optional Text Encoder model clip_l for All not found (search path: clip_l)

What's the deal with it?

[valery016]

And while we are on this... a new nuisance after installing v1.29: every time I do Connect to my custom Comfy server from the plugin's Configure dialogue, I notice this message in the server console (after a normal, error-free startup sequence):

To see the GUI go to: http://0.0.0.0:8190
Traceback (most recent call last):
File "C:\AI\StabilityMatrix\Packages\ComfyUI\custom_nodes\comfyui-tooling-nodes\api.py", line 145, in inspect_models
for filename in folder_paths.get_filename_list(model_type)
File "C:\AI\StabilityMatrix\Packages\ComfyUI\folder_paths.py", line 322, in get_filename_list
out = get_filename_list_(folder_name)
File "C:\AI\StabilityMatrix\Packages\ComfyUI\folder_paths.py", line 283, in get_filename_list_
folders = folder_names_and_paths[folder_name]
KeyError: 'unet_gguf'

I don't recall seeing this error before installing v1.29. This doesn't seem to affect the plugin's work (everything seems normal from within Krita AI), but I wonder why I am getting this, not having installed Flux at all or anything else gguf-related.

[Acly]

Ok, here goes. The update log section:
[...]

This looks all good as far as I can tell. Update worked, it migrated models to the new path ([server-path]/models), it extended the .yaml, and as far as I can see in the log, mat_places512_g_fp16 was found (along with everything else).

The old model folder ([server-path]/ComfyUI/models) shouldn't contain model files anymore, but you said you moved stuff their manually, so I'm guessing that's why?

Also on this subject: I could never get the plugin use the clip_l model in my config

It goes to the clip folder, not clip_vision

And while we are on this... a new nuisance after installing v1.29

I'll fix that (shouldn't print an error), but yes it doesn't have any impact since it just says it didn't find any GGUF models (which you don't have).

So I can't find anything wrong here? Was your error with custom StabilityMatrix comfy? I can't really help with that. If you fixed it by moving the models to the old folder, I can only assume that you at some point set it up that way! And it no longer worked because the updated moved the folder. That's to be expected.

[valery016]

The missing MAT_Places512_G_fp16 failure - as I found out now - didn’t have anything to do with Stability Matrix in the picture, but with the fact that the external Comfy was/is using junctions for folders in the plugin-managed one's folder tree (to avoid duplication), which were nullified during the v1.29 installation. But I think this is less relevant than it might sound, since it was just one of many examples of this kind of situation that I hear almost daily from folks on Discord (whom I am always glad to help, but my knowledge has its limits of course).

I’d really like to see more help from the log/diagnostic system of the plugin for both types of configuration, especially in show-stopping situations like this one. For starters. it would be much more helpful if during the startup sequence the plugin added to the error message strings like “(partial) match: MAT_Places512_G_fp16 …” and “INFO Optional Text Encoder model clip_l for All not found (search path: clip_l)” in the log file the folder name(s) where the plugin was looking for these components. Would this be feasible? That would save lots of guessing work for many users installing or updating the plugin, or otherwise modifying the setup.

It goes to the clip folder, not clip_vision

This worked, thanks! Could you shed a bit of light on which base models use this file and for what?

[Acly]

folder name(s) where the plugin was looking for these components. Would this be feasible?

Would be nice, but not so easy to have. The plugin doesn't know the folders. Would have to extend Comfy to query them.

Clip-L is used by pretty much all models, but in most cases it's part of the checkpoint