From 6c5c4794a008aac2de044dbe2a7682ff37ab808b Mon Sep 17 00:00:00 2001 From: Michael Habiger Date: Mon, 19 Feb 2024 14:44:37 -0600 Subject: [PATCH 1/2] Fix tuple append --- lib/sqlalchemy_ingres/base.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/sqlalchemy_ingres/base.py b/lib/sqlalchemy_ingres/base.py index bd72b78..876a92a 100644 --- a/lib/sqlalchemy_ingres/base.py +++ b/lib/sqlalchemy_ingres/base.py @@ -376,8 +376,9 @@ def get_primary_keys(self, connection, table_name, schema=None, **kw): try: rs = connection.exec_driver_sql(sqltext, params) - + return [row[0].rstrip() for row in rs.fetchall()] + finally: if rs: rs.close() @@ -558,7 +559,7 @@ def get_view_definition(self, connection, view_name, schema=None, **kw): if schema: sqltext += """ AND table_owner = ?""" - params(*params, self.denormalize_name(schema)) + params = (*params, self.denormalize_name(schema)) else: sqltext += """ AND table_owner != '$ingres'""" @@ -596,7 +597,7 @@ def get_indexes(self, connection, table_name, schema=None, **kw): if schema: sqltext += """ AND i.index_owner = ?""" - params(*params, self.denormalize_name(schema)) + params = (*params, self.denormalize_name(schema)) sqltext += """ ORDER BY From 1c26209ca55c751fdc0e2c5867ff7b9a1d38bbe9 Mon Sep 17 00:00:00 2001 From: Michael Habiger Date: Mon, 19 Feb 2024 15:20:31 -0600 Subject: [PATCH 2/2] Formatting reset --- lib/sqlalchemy_ingres/base.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/sqlalchemy_ingres/base.py b/lib/sqlalchemy_ingres/base.py index 876a92a..427c212 100644 --- a/lib/sqlalchemy_ingres/base.py +++ b/lib/sqlalchemy_ingres/base.py @@ -376,9 +376,8 @@ def get_primary_keys(self, connection, table_name, schema=None, **kw): try: rs = connection.exec_driver_sql(sqltext, params) - + return [row[0].rstrip() for row in rs.fetchall()] - finally: if rs: rs.close()