Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installing-from-source.rst #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update installing-from-source.rst #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/installing-from-source.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ Now activate the virtualenv in your current shell session:
.. code-block:: sh

# For bash/zsh users:
source ./venv/bin/activate
source ~/.venv/bin/activate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in virtual environment activation paths from ./venv to ~/.venv could lead to confusion since the virtual environment is initially created in the local directory (python3 -m venv venv). Users following the guide might not have a ~/.venv directory, leading to errors when trying to activate the virtual environment.

Suggested change
source ~/.venv/bin/activate
source ./venv/bin/activate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the mac, it creates a directory caled '.venv' with the period to make it a hidden directory. Thus you could resolve the bot dispute to: source ./.venv/bin/activate

# For Windows git bash users:
source ./venv/Scripts/activate
source ~/.venv/Scripts/activate
# For fish users:
source ./venv/bin/activate.fish
source ~/.venv/bin/activate.fish

All the modules need to be installed in the same env in order to avoid build issues. This is why creating a single venv for all activitywatch repos is important and why relying on poetry to setup a per-folder venv is not an option.

Expand Down