Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build for nightly Rust #38

Open
vidov0 opened this issue Jun 5, 2018 · 12 comments
Open

Can't build for nightly Rust #38

vidov0 opened this issue Jun 5, 2018 · 12 comments

Comments

@vidov0
Copy link

vidov0 commented Jun 5, 2018

Hi Adam,

Your library uses stdsimd as a external dependency crate, which landed in Rust std awhile ago.
It also uses an old target_feature attribute syntax that compiler complains about.
Do you plan on updating your library to compile with nightly Rust any time soon ?
If not, can you please advise me on how to do necessary changes in order to utilize your library,
since I am fairly new to Rust.

@AdamNiederer
Copy link
Owner

AdamNiederer commented Jun 5, 2018

I do intend to make this library compile with std::arch on nightly (and on stable as soon as cross-platform SIMD lands). I've been waiting for the cross-platform SIMD RFC to be merged (although I haven't checked in on it recently) before I continue, though.

Check the rust-2018-migration branch for a version of the library which emits fewer warnings and should compile on the current nightly.

EDIT 07/26/18: Use 0.5.0 on crates.io

@vidov0
Copy link
Author

vidov0 commented Jun 22, 2018

Hey Adam,

Stable Rust 1.27.0 with SIMD is out. Take a look at: https://blog.rust-lang.org/2018/06/21/Rust-1.27.html

@vidov0
Copy link
Author

vidov0 commented Jun 22, 2018

They mention your crate in the examples part ...

@yhql
Copy link

yhql commented Jun 23, 2018

Just for reference : rust-lang/stdarch#488
(stdsimd/coresimd should not be used from crates.io anymore)

@AdamNiederer
Copy link
Owner

Quick update: As of db60c96, faster will build on 06-19 nightly. Three tests fail because of name clashes. Once those are fixed, I will merge the rust 2018 branch and release a new major version to Cargo.

Also of interest: I should be able to build it on stable if I copy stdsimd's portable vectors into the codebase.

@vidov0
Copy link
Author

vidov0 commented Jun 24, 2018

Great news, thanks !

@mati865
Copy link

mati865 commented Jun 27, 2018

@AdamNiederer note that you cannot use cargo-features = ["edition"] on stable, you will have to disable it (and rust_2018_preview) then sed away all crate:: occurrences.

@prokopst
Copy link

Any news?

@AdamNiederer
Copy link
Owner

AdamNiederer commented Jul 27, 2018

0.5.0 should compile on the current nightly. Are you having any trouble with it?

EDIT: Oh, they removed core::simd from the standard library a few days ago. We just started compiling on master again!

@vidov0
Copy link
Author

vidov0 commented Jul 27, 2018

I've also noticed they removed core::simd - no idea why.
core::simd still present in nightly-2018-07-19

@mati865
Copy link

mati865 commented Jul 27, 2018

coresimd was accidentally stabilised, it's fixed now.

@ZhangHanDong
Copy link

Compiling faster v0.5.0
error[E0433]: failed to resolve. Maybe a missing`extern crate std;`?
  --> /Users/blackanger/.cargo/registry/src/mirrors.ustc.edu.cn-15f9db60536bad60/faster-0.5.0/src/vecs.rs:10:12
   |
10 | use crate::std::fmt::Debug;
   |            ^^^ Maybe a missing `extern crate std;`?

error[E0433]: failed to resolve. Maybe a missing`extern crate std;`?
 --> /Users/blackanger/.cargo/registry/src/mirrors.ustc.edu.cn-15f9db60536bad60/faster-0.5.0/src/iters.rs:9:12
  |
9 | use crate::std::slice::from_raw_parts;
  |            ^^^ Maybe a missing `extern cratestd;`?

error[E0433]: failed to resolve. Maybe a missing`extern crate std;`?
 --> /Users/blackanger/.cargo/registry/src/mirrors.ustc.edu.cn-15f9db60536bad60/faster-0.5.0/src/intrin/eq.rs:8:12
  |
8 | use crate::std::ops::BitXor;
  |            ^^^ Maybe a missing `extern cratestd;`?

error[E0433]: failed to resolve. Maybe a missing`extern crate std;`?
  --> /Users/blackanger/.cargo/registry/src/mirrors.ustc.edu.cn-15f9db60536bad60/faster-0.5.0/src/arch/x86/intrin/abs.rs:14:12
   |
14 | use crate::std::mem::transmute;
   |            ^^^ Maybe a missing `extern crate std;`?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants