-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPT-81] Home: Redesign carousel to show both Mentee and Mentor testimonials #735
Comments
Assigned to @jcc-kh for design ideation. |
@jcc-kh, I have created a design mockup for the mobile version of the carousell, do let me know what you think: ![]() |
Now that I look at it, looks a bit weird that the photos are not entirely in the box, would it be possible if both the mobile and laptop versions of photos have the photos in the box and aligned with the paragraph (meaning the name, organisation & title) also shift inwards, photo is outermost but still aligned with paragraph) |
Some comments:
That said, I think the current design is already good enough for MVP - in the interest of time (since we ought to finish preparing the website by end of this month), could we get this implemented first? |
@wei2912 I'm wondering if it would be better for name, organisation and title to be in the same line |
@ykIsCoding I'll reach out to @w3joe to get the code for the PR, can just look through the design and code, then discuss with me and @jcc-kh on how to proceed. |
https://flowbite.com/docs/components/carousel/ might be useful we aren't currently using Flowbite but I'm okay to import it (see https://flowbite.com/docs/getting-started/quickstart/) |
@ykIsCoding could you include your Figma link? thanks! @jcc-kh for your review :P |
@jcc-kh to get back to @ykIsCoding on the design soon |
hihi, we had decided against displaying the mentor & mentee testimonials side by side. it is likely that depending on the different user (mentee or mentor), they are more likely to be focused on 1 type of testimonial (either mentee or mentor) and currently i’m thinking of a card display format for the testimonials that users can scroll through in a carousel format rather than the symmetrical format as proposed by YK. will discuss more with jessie & get back to u? |
Currently, we have a single column with a tag saying Mentor/Mentee:
Since we plan to feature a mentee/mentor side-by-side, there should be two columns with the carousel controlling both.
Before starting on code, a design mockup should be created first.
From SyncLinear.com | MPT-81
The text was updated successfully, but these errors were encountered: