Name clashes between trait decls and trait impls

[sonmarcho]

There are often clash names between trait decls and impls of the following shape (the impl is for a variable which has a trait bound, rather than a more complex type like Vec<T>, etc.):

trait Into<T> {
    fn into(self) -> T;
}

impl<T, U: From<T>> Into<U> for T {
  fn into(self) -> U { U::From(self) }
}

Both the trait declaration and the impl get extracted with the same name (Into). We should use the trait bounds in the name generation to avoid this kind of clashes.

[sonmarcho]

There are also name clashes because of implementations of the following shape:

impl<T> From<T> for T {
  fn from(self) -> T { self }
}

[Nadrieril]

The technical term for such an impl is a "blanket impl". When generating a name for an impl, you could detect this case and rename it to something like From_blanket. And then indeed disambiguate between the blanket impls by taking bounds into account.