Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Pin all the versions #20

Closed
yakryder opened this issue Mar 10, 2019 · 5 comments
Closed

Discuss: Pin all the versions #20

yakryder opened this issue Mar 10, 2019 · 5 comments

Comments

@yakryder
Copy link
Collaborator

Don't want to be the guy who just submits a PR with a big change without talking it over first.

Pinning the versions of all project dependencies is a habit I picked up from Elm. A chunk of this could be done in tandem with #15.

Thoughts?

@FedericoEsparza
Copy link
Member

FedericoEsparza commented Mar 10, 2019

@Sherspock I agree. Let's pin the versions using the ~ tilde operator (e.g. "~1.2.3"). I still like the security patches to get in, but the caret operator ^ is a bit too liberal, and only pins to the major semantic version.

It can be done independently of #15 (meaning, before or after).

Go for it!

Thanks for bringing it up.

@yakryder
Copy link
Collaborator Author

Sounds great

@yakryder
Copy link
Collaborator Author

This was just an input-gathering ticket. Implementation ticket is #37.

If you disagree with the proposed solution, please share your thoughts. There is still time for this issue to be reopened and the implementation ticket changed.

@ghost ghost removed the backlog label Apr 11, 2019
@FedericoEsparza
Copy link
Member

@Sherspock Thanks for updating the tickets and cleaning up the board, Ryder!

@yakryder
Copy link
Collaborator Author

@FedericoEsparza Absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants