Skip to content

Commit

Permalink
Removed executor fixture and using aliases for functional tests (#56)
Browse files Browse the repository at this point in the history
* removed executor fixture and using aliases

* updated changelog
  • Loading branch information
AlejandroEsquivel authored Dec 6, 2022
1 parent 946df71 commit eb663c9
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 33 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Changed

- Using executor aliases instead of classes for functional tests

## [0.24.0] - 2022-12-06

### Changed
Expand Down
4 changes: 1 addition & 3 deletions tests/functional_tests/basic_workflow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@
import covalent as ct
import pytest

from tests.functional_tests.fixtures.executor import executor

# Basic Workflow


@pytest.mark.functional_tests
def test_basic_workflow():
@ct.electron(executor=executor)
@ct.electron(executor="ecs")
def join_words(a, b):
return ", ".join([a, b])

Expand Down
Empty file.
27 changes: 0 additions & 27 deletions tests/functional_tests/fixtures/executor.py

This file was deleted.

4 changes: 1 addition & 3 deletions tests/functional_tests/svm_workflow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
import covalent as ct
import pytest

from tests.functional_tests.fixtures.executor import executor

deps_pip = ct.DepsPip(packages=["numpy==1.22.4", "scikit-learn==1.1.2"])


Expand All @@ -40,7 +38,7 @@ def load_data():
iris.target = iris.target[perm]
return iris.data, iris.target

@ct.electron(executor=executor, deps_pip=deps_pip)
@ct.electron(executor="ecs", deps_pip=deps_pip)
def train_svm(data, C, gamma):
X, y = data
clf = svm.SVC(C=C, gamma=gamma)
Expand Down

0 comments on commit eb663c9

Please sign in to comment.