feat: added event handler for saving ibc channels #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!packetSrcPortAttr || packetSrcPortAttr.value !== TRANSFER_PORT_VALUE) { | ||
| logger.warn("packet_src_port is not transfer"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is it possible that event attributes are not encoded? While working on indexing balances, I noticed that some events had attributes that were not encoded.
There was a problem hiding this comment.
yes it is possible. in fact, packet_src_port is not encoded
toliaqat
reviewed
May 5, 2024
schema.graphql
Outdated
| channel: IBCChannel! | ||
| srcAccount: Account! | ||
| destAccount: Account! | ||
| denomination: String! |
src/mappings/mappingHandlers.ts
Outdated
| amount, | ||
| TransferType.SEND, | ||
| ); | ||
| transferRecord.save(); |
There was a problem hiding this comment.
Should await on the returned value of .save() otherwise the record might not get saved.
src/mappings/mappingHandlers.ts
Outdated
| amount, | ||
| TransferType.RECEIVE, | ||
| ); | ||
| transferRecord.save(); |
src/mappings/mappingHandlers.ts
Outdated
| const generatedEscrowAddress = getEscrowAddress(TRANSFER_PORT_VALUE, channelName); | ||
|
|
||
| const channelRecord = new IBCChannel(channelName, channelName, generatedEscrowAddress); | ||
| channelRecord.save(); |
There was a problem hiding this comment.
await on .save() return value.
frazarshad
force-pushed
the
feat/ibc-channel-indexing
branch
from
1349849
to
61f86a4
Compare
toliaqat
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new handlers that check for IBC send and recieve transactions.
On each IBC transaction, we save the data for the transaction as well as data about the channel the tranaction occurred on
It introduces two models for this purpose
IBCChannelandIBCTransferIBCChannel
IBCTransfer
