Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed issue with dailyVaultStates counter #22

Merged
merged 1 commit into from
May 26, 2024
Merged

fix: fixed issue with dailyVaultStates counter #22

merged 1 commit into from
May 26, 2024

Conversation

frazarshad
Copy link
Collaborator

Updated the conditions that checked whether the state change was valid. These conditions were complicated and might have missed an edge case. removed all of these
simplifying this results in handling of any possible vault state change

Tested the possible state changes here is their logs:

subquery-node_1   | 2024-05-25T07:17:07.335Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.336Z <sandbox-#2> INFO undefined => active 
subquery-node_1   | 2024-05-25T07:17:07.336Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.339Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.340Z <sandbox-#2> INFO undefined => closed 
subquery-node_1   | 2024-05-25T07:17:07.340Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.345Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.345Z <sandbox-#2> INFO undefined => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.345Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.352Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.352Z <sandbox-#2> INFO undefined => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.352Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.357Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.357Z <sandbox-#2> INFO undefined => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.357Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.379Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.379Z <sandbox-#2> INFO active => active 
subquery-node_1   | 2024-05-25T07:17:07.379Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.389Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.389Z <sandbox-#2> INFO active => closed 
subquery-node_1   | 2024-05-25T07:17:07.389Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "-1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.395Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.395Z <sandbox-#2> INFO active => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.396Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "-1",
subquery-node_1   |   "liquidated": "1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.405Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.405Z <sandbox-#2> INFO active => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.405Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "-1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.415Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.415Z <sandbox-#2> INFO active => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.415Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "-1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.428Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.428Z <sandbox-#2> INFO closed => active 
subquery-node_1   | 2024-05-25T07:17:07.428Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "-1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.462Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.462Z <sandbox-#2> INFO closed => closed 
subquery-node_1   | 2024-05-25T07:17:07.462Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.469Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.469Z <sandbox-#2> INFO closed => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.469Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "-1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.483Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.483Z <sandbox-#2> INFO closed => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.484Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "1",
subquery-node_1   |   "closed": "-1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.491Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.491Z <sandbox-#2> INFO closed => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.491Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "-1",
subquery-node_1   |   "liquidatedClosed": "1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.501Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.502Z <sandbox-#2> INFO liquidated => active 
subquery-node_1   | 2024-05-25T07:17:07.502Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "1",
subquery-node_1   |   "liquidated": "-1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.508Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.508Z <sandbox-#2> INFO liquidated => closed 
subquery-node_1   | 2024-05-25T07:17:07.508Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "-1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.517Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.517Z <sandbox-#2> INFO liquidated => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.517Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.525Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.525Z <sandbox-#2> INFO liquidated => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.525Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "-1",
subquery-node_1   |   "liquidating": "1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.535Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.535Z <sandbox-#2> INFO liquidated => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.535Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "-1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.545Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.545Z <sandbox-#2> INFO liquidating => active 
subquery-node_1   | 2024-05-25T07:17:07.545Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "-1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.551Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.551Z <sandbox-#2> INFO liquidating => closed 
subquery-node_1   | 2024-05-25T07:17:07.551Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "-1",
subquery-node_1   |   "closed": "1",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.560Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.561Z <sandbox-#2> INFO liquidating => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.561Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "1",
subquery-node_1   |   "liquidating": "-1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.570Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.571Z <sandbox-#2> INFO liquidating => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.571Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.578Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.578Z <sandbox-#2> INFO liquidating => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.578Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "-1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.592Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.592Z <sandbox-#2> INFO liquidatedClosed => active 
subquery-node_1   | 2024-05-25T07:17:07.592Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "1",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "-1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.605Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.605Z <sandbox-#2> INFO liquidatedClosed => closed 
subquery-node_1   | 2024-05-25T07:17:07.605Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "1",
subquery-node_1   |   "liquidatedClosed": "-1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.616Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.616Z <sandbox-#2> INFO liquidatedClosed => liquidated 
subquery-node_1   | 2024-05-25T07:17:07.616Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "1",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "-1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.623Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.623Z <sandbox-#2> INFO liquidatedClosed => liquidating 
subquery-node_1   | 2024-05-25T07:17:07.623Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "1",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "-1"
subquery-node_1   | } 
subquery-node_1   | 2024-05-25T07:17:07.631Z <sandbox-#2> INFO 10724784 
subquery-node_1   | 2024-05-25T07:17:07.631Z <sandbox-#2> INFO liquidatedClosed => liquidatedClosed 
subquery-node_1   | 2024-05-25T07:17:07.631Z <sandbox-#2> INFO {
subquery-node_1   |   "active": "0",
subquery-node_1   |   "liquidated": "0",
subquery-node_1   |   "liquidating": "0",
subquery-node_1   |   "closed": "0",
subquery-node_1   |   "liquidatedClosed": "0"
subquery-node_1   | }

@frazarshad frazarshad requested a review from toliaqat May 25, 2024 07:26
@toliaqat toliaqat merged commit 49d5bd3 into main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toliaqat toliaqat toliaqat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frazarshad @toliaqat