feat: index balance events

[rabi-siddique]

No description provided.

[toliaqat]

I think we should not limit just to BLD, and instead let any token balance be indexed.

[rabi-siddique]

Yeah, we can do that. We'll need to discuss the schema design for that.
With the current schema, we'll be updating the same amount field for each token.

[toliaqat]

I recommend removing the if condition and replacing it with lambda operation like below. Also suggesting two log statements that works for both scenarios.

      newBalance = operation(currentBalance, amount);

      if (newBalance < 0) {
        logger.error(
          `Attempt to update ${amount} would result in a negative balance. Current balance: ${currentBalance}.`
        );
        return;
      }
      balance.balance = newBalance;
      logger.info(
        `Updated balance for ${address} by ${amount}. New balance: ${balance.balance}`
      );

[toliaqat]

Suggested change

	for (let denom of supportedDenominations) {
	if (coin.endsWith(denom)) {
	result.isValidTransaction = true;
	result.coins.push({ amount: coin.slice(0, -denom.length), denom });
	}
	}
	result.isValidTransaction = true;
	result.coins.push({ amount: (coin.match(/^\d+/) || [""])[0] , denom: (coin.match(/[a-zA-Z]+.*$/) || [""])[0] });

[rabi-siddique]

This is convenient. Should we add this snippet now? It will index another token with the denomination ibc/someHugeNumber that I've seen in the logs.

[frazarshad]

ibc/someHugeNumber is a fungible token created when a token is recieved from another chain through an IBC transaction.
the number after it might mess with the regex that @toliaqat has suggested

[frazarshad]

how does this function assume the value isnt decoded?
an encoded event might look like this:

{
    type: 'foo',
    attributes: [
        {
            key: "asdjkhasd",
            value: "nasjdh23",
    ]
}

the value here will be b64 encoded but it will still be truthy, so shouldnt this function return a false negative?

[rabi-siddique]

It checks whether the key has the value amount. If it does, the data is decoded. If it doesn't, the data is encoded. You will need to look getAttributeValue for more details. We're tracking events that must have an amount present in the object

[rabi-siddique]

Also, I skimmed your PR for IBC on Friday........Maybe I'll reuse your code for decoding/encoding.

[frazarshad]

ibc/someHugeNumber is a fungible token created when a token is recieved from another chain through an IBC transaction.
the number after it might mess with the regex that @toliaqat has suggested