Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused type-coverage #104

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Oct 15, 2024

@mujahidkay mujahidkay self-assigned this Oct 15, 2024
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see type-coverage used anywhere. I suspect it's copy-pasta from another package.json. Instead of pinning just remove it.

In the interests of time I've pushed such a commit. So I'm approving the PR in that state.

I suggest squashing by updating the PR title and using Github's squash merge option

@mujahidkay mujahidkay changed the title ci: version lock type-coverage-core chore(deps): remove unused type-coverage Oct 15, 2024
@mujahidkay
Copy link
Member Author

mujahidkay commented Oct 15, 2024

I don't see type-coverage used anywhere. I suspect it's copy-pasta from another package.json. Instead of pinning just remove it.

In the interests of time I've pushed such a commit. So I'm approving the PR in that state.

I suggest squashing by updating the PR title and using Github's squash merge option

Yeah I only see it being used in scripts/update-typeCoverage-floor.sh which isn't being invoked anywhere in agoric-sdk. I'm assuming it was used on need basis and isn't something we use anymore?

nvm wrong repo. you're right.

@mujahidkay mujahidkay merged commit 5f6f4b8 into main Oct 15, 2024
3 checks passed
@mujahidkay mujahidkay deleted the muneeb/fix-type-coverage-core branch October 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants