[Hackathon] Subscription service contract #98
Conversation
rabi-siddique
force-pushed
the
subscription-service-contract
branch
2 times, most recently
from
e35ab95
to
a2170f7
Compare
rabi-siddique
force-pushed
the
subscription-service-contract
branch
3 times, most recently
from
3166cfc
to
f4c8025
Compare
rabi-siddique
force-pushed
the
subscription-service-contract
branch
from
f4c8025
to
7d0049e
Compare
…oric/dapp-offer-up into subscription-service-contract
rabi-siddique
force-pushed
the
subscription-service-contract
branch
from
6a6b2cc
to
e89f98d
Compare
Muneeb147
changed the title
contract/src/offer-up-proposal.js
Outdated
| @@ -66,8 +69,12 @@ export const startOfferUpContract = async permittedPowers => { | |||
|
|
|||
| const istIssuer = await istIssuerP; | |||
| const istBrand = await istBrandP; | |||
| const timerService = await await chainTimerServiceP; | |||
There was a problem hiding this comment.
I don't know whether await await breaks anything, but it's at best unnecessary.
contract/src/offer-up.contract.js
Outdated
| const { want } = buyerSeat.getProposal(); | ||
| const tradeHandler = async (buyerSeat, offerArgs) => { | ||
| // @ts-ignore | ||
| const userAddress = offerArgs.userAddress; |
There was a problem hiding this comment.
what's the goal here?
This address is forgeable.
Can you key the map on seats instead of addresses?
contract/src/offer-up.contract.js
Outdated
| */ | ||
| export const start = async zcf => { | ||
| const { tradePrice, maxItems = 3n } = zcf.getTerms(); | ||
| const { | ||
| timerService, |
There was a problem hiding this comment.
The timer service is sufficiently powerful that it should be closely held; i.e. passed in privateArgs rather than terms.
The main power that's risky is the power to schedule wake-ups. You don't seem to be using that here. Perhaps use getClock before starting the contract and pass in the resulting Clock in terms.
See also:
| import netflixLogo from '../assets/netflix.svg'; | ||
| import disneyLogo from '../assets/disney.svg'; | ||
| import hboLogo from '../assets/hbomax.svg'; | ||
| import primeLogo from '../assets/amazon.svg'; |
There was a problem hiding this comment.
I'm pretty sure these are registered trademarks, not to be used without permission. OK for a hackathon, but we can't keep the code around long.
contract/package.json
Outdated
| @@ -47,6 +47,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@agoric/ertp": "^0.16.3-u12.0", | |||
| "@agoric/time": "^0.3.3-u16.0", | |||
There was a problem hiding this comment.
dapp dependencies are, unfortunately, tremendously fragile. Mixing u12 and u16 is asking for trouble, IME.
We should probably have a better scoped issue, but the tale of woe is in...
There was a problem hiding this comment.
I tried rolling back to the u12 version of @agoric/time (60e2308) but the symptoms remain.
| give: { Price: M.gte(tradePrice) }, | ||
| want: { Items: { brand: itemBrand, value: M.bag() } }, | ||
| give: { Price: M.eq(subscriptionPrice) }, | ||
| want: { Items: { brand: M.any(), value: M.bag() } }, |
| return subscriptionResources[serviceType]; | ||
| } else { | ||
| // User doesn't have a valid subscription | ||
| return 'Access denied: You do not have a valid subscription.'; |
There was a problem hiding this comment.
@samsiegart what was the hackathon project you worked on where services would look for NFTs in wallets (using vstorage queries) to gate access?
Ah... right... https://github.com/agoric-labs/agoric-passport-express
There was a problem hiding this comment.
This is nifty stuff. Please consider putting it in a fork in https://github.com/agoric-labs .
My "request changes" is to block accidentally landing it here.
No description provided.