Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: input tag for a3p #162

Merged
merged 2 commits into from
Aug 26, 2024
Merged

ci: input tag for a3p #162

merged 2 commits into from
Aug 26, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Aug 26, 2024

Adding support to test the a3p chain with custom tags.

Copy link

cloudflare-workers-and-pages bot commented Aug 26, 2024

Deploying dapp-psm with  Cloudflare Pages  Cloudflare Pages

Latest commit: a71db29
Status: ✅  Deploy successful!
Preview URL: https://65ac4c1c.dapp-psm.pages.dev
Branch Preview URL: https://rs-custom-tag-for-a3p.dapp-psm.pages.dev

View logs

Copy link

github-actions bot commented Aug 26, 2024

Cloudflare deployment logs are available here

Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have we tested it on any other repo? Because e2e_tests.yml must always be picked from "main" branch

@rabi-siddique
Copy link
Contributor Author

Looks good. Have we tested it on any other repo? Because e2e_tests.yml must always be picked from "main" branch

I didn't do a lot of testing in this DApp, but this change was fully tested in the wallet-app and then applied to all DApps. I'm confident it works because the CI jobs for this PR picked the correct tag value.

@rabi-siddique rabi-siddique merged commit f09043e into main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants