Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow format to be used according to the current locale #420

Open
luiz-soares opened this issue Jan 2, 2023 · 1 comment
Open

allow format to be used according to the current locale #420

luiz-soares opened this issue Jan 2, 2023 · 1 comment

Comments

@luiz-soares
Copy link
Contributor

luiz-soares commented Jan 2, 2023

Each Locale has a default regarding the usage of periods when defining times (AM/PM).

While some might play nice with both 12h or 24h hours format, a default still exists and is the most common for that locale, and some cases

It would be nice if we could leave format input empty and go with the Locale default regarding periods.

I understand this would be a breaking change, so perhaps we start keeping as 12 but allowing it to be set to null/undefined and then do not override its property when asking luxon to do the formatting.

I can work on this, let me know if you're ok with this approach.

@Agranom
Copy link
Owner

Agranom commented Jun 14, 2023

Hi. You can work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants