Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect transitions #826

Closed
jwingefeld opened this issue Apr 6, 2020 · 10 comments · Fixed by #3311
Closed

Effect transitions #826

jwingefeld opened this issue Apr 6, 2020 · 10 comments · Fixed by #3311
Assignees

Comments

@jwingefeld
Copy link
Contributor

I just realized that the color fade which transitions from one color to another only works on the first segment. The second segment switches to the new color instantaneously while the first segment slowly fades over.

WLED Version: latest version from master branch.

I'll provide a video in discord.

@Aircoookie
Copy link
Owner

Thank you!

Yes, unfortunately the transition logic is old and doesn't support any segments but the main segment (the first segment 0 by default).
I plan on replacing it with "transitional effects" in the future, which will also support smoothly fading between different effects!

@stale
Copy link

stale bot commented Aug 4, 2020

Hey! This issue has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for using WLED!

@stale stale bot added the stale This issue will be closed soon because of prolonged inactivity label Aug 4, 2020
@DarkFox
Copy link

DarkFox commented Aug 5, 2020

Have you gotten any closer to implementing transition effects? Otherwise, it might be worthwhile to fix the regular transition for segments.

@stale stale bot removed the stale This issue will be closed soon because of prolonged inactivity label Aug 5, 2020
@Aircoookie Aircoookie changed the title Color fade only works on first segment Transition for all segments Aug 5, 2020
@Aircoookie Aircoookie added this to the 0.12.0 milestone Aug 31, 2020
@timhere
Copy link

timhere commented Mar 10, 2021

I've just encountered this issue, I'm trying to connect to WLED using the json api, and no matter how I try the transitions are only applied to the first segment. For example:

{
	
	"tt": 10,
	"bri": 255,
	"seg":[
		{"col":[[255,0,0]]},
		{"col":[[0,255,0]]},
		{"col":[[0,0,255]]}
	]
}

I see a gentle transition to green on the first segment, but the following two just switch immediately.

As a different approach I also addressing individual LEDs on a single segment:

{
	
	"tt": 10,
	"bri": 255,
	"seg": {
		"i": [
			0,10,[255,0,0],
			10,20,[0,255,0],
			20,30,[0,0,255]
		]
	}
}

...but still no luck! In this case all LEDs switch immediately.

Another workaround I've considered is creating a preset for each state I need, but I'm not sure that's an optimal solution.

@Aircoookie it's great that this is on your horizon! How do you plan for transitional effects to work when interacting over the API?

@Aircoookie Aircoookie modified the milestones: 0.12.0, 0.13.0 Apr 6, 2021
@Aircoookie
Copy link
Owner

An update on this: In the new v0.12.0 release, color and brightness transitions are now supported on all segments! Effect transitions are still not supported though, therefore this issue will stay open.

@timhere
Copy link

timhere commented Apr 6, 2021

Great news!

@Aircoookie Aircoookie changed the title Transition for all segments Effect transitions Apr 10, 2021
@blazoncek
Copy link
Collaborator

This is now supposedly fully fixed in 0.13-b3 including segment transitions. Closing.
Feel free to reopen if you find transitions not working correctly still.

@Aircoookie
Copy link
Owner

Thank you, let's keep this one open though. Brightness, color and on/off are now fully supported, but not yet smooth transitions between different effect modes.

@Aircoookie Aircoookie reopened this Oct 3, 2021
@Aircoookie Aircoookie modified the milestones: 0.13.0, 1.0.0 Oct 3, 2021
@softhack007 softhack007 added the stale This issue will be closed soon because of prolonged inactivity label Jan 30, 2023
@blazoncek
Copy link
Collaborator

I managed to get effect transitions working. 😀

@stale stale bot removed the stale This issue will be closed soon because of prolonged inactivity label Aug 5, 2023
@blazoncek blazoncek self-assigned this Aug 5, 2023
@blazoncek
Copy link
Collaborator

Will be solved with #3311.

@blazoncek blazoncek linked a pull request Aug 9, 2023 that will close this issue
@softhack007 softhack007 removed this from the 1.0.0 milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants