-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: BIDS functionality #6
Comments
need a better system for determining if a bids derivatives is expected when using derivatives for caching. for instance, if the user employs the cmdline flag to skip motion correction, then the mc transform is not supplied to the outputnode and the derivative is not created. And in this case, the mc transfrom derivative should not be expected when doing a derivatives cache check for the pipeline. or what if the user does not want to perform a brain extraction - that derivative should not be required in the derivatives folder. |
Checking whether the output node has a connection to the attribute from which the derivative is derived is likely the best way to determine if the derivate should exist. |
@mklassen Now consider an owner workflow B which uses A. B does not override A's commandline options and therefore does not know if A will or will not have something hooked up to outputnode.mask. However, B figures that a mask - if it is calculated - is useful and so it hooks up A.outputnode.mask to B.outputnode.mask. Now we decide to extend B into a BIDS workflow and want B.outputnode.mask to be hooked up to a BIDS derivative. In this case, we cannot check B's outpnode connections to know if a mask is actually being output as a derivative. I can see 2 ways forward:
|
For now ignore the issue. The worst that can happen is the user recomputes something unnecessarily. I think dealing with #17 will alleviate a lot of these types of issues and make the design a lot simpler. So leave the issue for v2 |
No description provided.
The text was updated successfully, but these errors were encountered: