internalコンストラクタの冗長なデフォルト引数を削除

AlesInfiny · Feb 29, 2024 · b82b80b · b82b80b
1 parent 020f577
commit b82b80b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/samples/Dressca/dressca-backend/src/Dressca.Web/Baskets/BuyerIdFilterAttribute.cs b/samples/Dressca/dressca-backend/src/Dressca.Web/Baskets/BuyerIdFilterAttribute.cs
@@ -29,23 +29,23 @@ public class BuyerIdFilterAttribute : ActionFilterAttribute
     ///  <paramref name="buyerIdCookieName"/> が <see langword="null"/> です。
     /// </exception>
     public BuyerIdFilterAttribute(string buyerIdCookieName = DefaultBuyerIdCookieName)
-        : this(TimeProvider.System, buyerIdCookieName)
+        : this(buyerIdCookieName, TimeProvider.System)
     {
     }
 
     /// <summary>
     ///  <see cref="BuyerIdFilterAttribute"/> クラスの新しいインタンスを初期化します。
     ///  単体テスト用に<see cref="TimeProvider"/> を受け取ることができます。
     /// </summary>
+    /// <param name="buyerIdCookieName">Cookie のキー名。</param>
     /// <param name="timeProvider">日時のプロバイダ。通常はシステム日時。</param>
-    /// <param name="buyerIdCookieName">Cookie のキー名。未指定時は "Dressca-Bid" 。</param>
     /// <exception cref="ArgumentNullException">
     ///  <paramref name="timeProvider"/> が <see langword="null"/> です。
     /// </exception>
-    internal BuyerIdFilterAttribute(TimeProvider timeProvider, string buyerIdCookieName = DefaultBuyerIdCookieName)
+    internal BuyerIdFilterAttribute(string buyerIdCookieName, TimeProvider timeProvider)
     {
-        this.timeProvider = timeProvider ?? throw new ArgumentNullException(nameof(timeProvider));
         this.buyerIdCookieName = buyerIdCookieName ?? throw new ArgumentNullException(nameof(buyerIdCookieName));
+        this.timeProvider = timeProvider ?? throw new ArgumentNullException(nameof(timeProvider));
     }
 
     /// <inheritdoc/>

diff --git a/...Dressca/dressca-backend/tests/Dressca.UnitTests/Web/Baskets/BuyerIdFilterAttributeTest.cs b/...Dressca/dressca-backend/tests/Dressca.UnitTests/Web/Baskets/BuyerIdFilterAttributeTest.cs
@@ -15,6 +15,7 @@ public class BuyerIdFilterAttributeTest
     public void Cookieの有効期限は7日間()
     {
         // Arrange
+        var buyerIdCookieName = "Dressca-Bid";
         var httpContext = new DefaultHttpContext();
         var actionContext = new ActionContext(httpContext, new RouteData(), new ActionDescriptor());
         var context = new ActionExecutedContext(actionContext, new List<IFilterMetadata>(), Mock.Of<Controller>());
@@ -23,7 +24,7 @@ public void Cookieの有効期限は7日間()
         fakeTimeProvider.SetUtcNow(testCookieCreatedDateTime);
         var expectedDateTime = testCookieCreatedDateTime.AddDays(7);
         var formattedExpectedDateTime = expectedDateTime.ToString("ddd, dd MMM yyyy HH:mm:ss 'GMT'", CultureInfo.InvariantCulture);
-        var filter = new BuyerIdFilterAttribute(fakeTimeProvider);
+        var filter = new BuyerIdFilterAttribute(buyerIdCookieName, fakeTimeProvider);
 
         // Act
         filter.OnActionExecuted(context);