Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #5

Open
jon4hz opened this issue Jun 4, 2021 · 6 comments
Open

New release #5

jon4hz opened this issue Jun 4, 2021 · 6 comments

Comments

@jon4hz
Copy link

jon4hz commented Jun 4, 2021

Currently if you try to import that repo it automatically grabs the release v0.0.15 which is not compatible with go-ethereum releases after 1.9.25. However it seems like that this issue was already addressed a few months ago.
So would it be possible to make a new release?

@jon4hz
Copy link
Author

jon4hz commented Jun 4, 2021

For everyone else running in this issue in the meantime: go get github.com/alethio/web3-multicall-go@9249f76c1578cf90b7bc239049b858b9db3633fa grabs the latest changes :)

@journeytosilius
Copy link

and how do you import it ? I get import error when I install it this way ... Thanks !

@jon4hz
Copy link
Author

jon4hz commented Feb 21, 2022

At the time I opened that issue, I defined the exact commit of the library in the go.mod file. However in the meantime I forked the repository to https://github.com/jon4hz/web3-multicall-go, made some small changes and create a new release.

@journeytosilius
Copy link

thanks ! If I run the example with ETH RPC and ETH addresses it works, but when I switch to, for example Fantom it fails. My program is setup to accept any network, but this library fails when I switch. Is there something that I have to add to the library for other ERC20 based networks to work as well ? Maybe there is something hardcoded for ETH only ? The multicall contract I'm using is the same as the one you use on the example but on Fantom. Thanks for keeping this up. If changes are required for other networks I might subnmit a PR on your fork ? Thanks

@jon4hz
Copy link
Author

jon4hz commented Feb 22, 2022

The multicall contract address is hardcoded but you can simply pass in a string when creating the multicall client like this:

contract := "0xContractAddress"
multicall.New(eth, multicall.ContractAddress(contract))

The contract is deployed on the following networks:

BSC: 0x6Cf63cC81660Dd174A49e0C61A1f916456Ee1471
Polygon: 0x8a233a018a2e123c0D96435CF99c8e65648b429F
Fantom: 0x08AB4aa09F43cF2D45046870170dd75AE6FBa306
BSC Testnet: 0xD3c6D8dAa57dfD38609047447cccDEF7Db6631b5
Ropsten: 0x5Efdd3fb0ab27A307FE806f5c7CEDd3217b3904a

@journeytosilius
Copy link

thanks for this, will take a look asap !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants