Merge pull request #2853 from dpayne/fix_use_after_free_on_task_close

Alexays · Jan 22, 2024 · 27fec51 · 27fec51
2 parents 6e12f81 + 53233e4
commit 27fec51
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/modules/wlr/taskbar.cpp b/src/modules/wlr/taskbar.cpp
@@ -527,11 +527,11 @@ void Task::handle_closed() {
   spdlog::debug("{} closed", repr());
   zwlr_foreign_toplevel_handle_v1_destroy(handle_);
   handle_ = nullptr;
-  tbar_->remove_task(id_);
   if (button_visible_) {
     tbar_->remove_button(button);
     button_visible_ = false;
   }
+  tbar_->remove_task(id_);
 }
 
 bool Task::handle_clicked(GdkEventButton *bt) {