-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync development
into main
#750
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/astral-sh/ruff-pre-commit: v0.3.2 → v0.3.3](astral-sh/ruff-pre-commit@v0.3.2...v0.3.3) - [github.com/pre-commit/mirrors-prettier: v3.0.3 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.0.3...v4.0.0-alpha.8)
[pre-commit.ci] pre-commit autoupdate
changed argument to predict_cellassign to make things conistent
Change Anndata extension to h5ad
Co-authored-by: Joshua Shapiro <[email protected]>
Make example ids consistent
…g-when-no-cells Skip processing if no cells remain after empty droplet filtering
Co-authored-by: Joshua Shapiro <[email protected]>
Skip CellAssign if only 1 cell
…ecify-demux-version
This reverts commit ecd5de5.
This reverts commit 71b3f63.
…version Account for demultiplexing without genetic demultiplexing
Account for .h5ad in output feature file
…ssing-samples Account for no cells being assigned to a sample when demultiplexing
Update tags to v0.8.1
sjspielman
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 everything seems in place given the changes I expect, and stub check passes so that's all good enough for me!
This was referenced Apr 23, 2024
Closing this in favor of #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing towards #748, this syncs all the changes in
development
withmain
. This includes a bunch of small fixes and the change to use.h5ad
file extensions.