Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need cluster_sce()? #212

Open
jashapiro opened this issue Aug 15, 2023 · 2 comments
Open

Do we need cluster_sce()? #212

jashapiro opened this issue Aug 15, 2023 · 2 comments

Comments

@jashapiro
Copy link
Member

I just noted that there is already a function scran::clusterCells() which does almost everything we do with cluster_sce(), with the exception being saving the results back to a separate SCE object.

Since we can add the cluster info with a line like:

sce$clusters <- scran::clusterCells(
  sce, 
  use.dimred = "PCA", 
  BLUSPARAM=NNGraphParam(k=15)
)

are we sure we need our own version of the function?

@allyhawkins
Copy link
Member

hmm probably not... do we want to take this out before we release?

@allyhawkins
Copy link
Member

This function is only used in internal functions within the package and we don't use it in other places like scpca-downstream-analyses. Because of that, we will just remove it from being exported right now and go ahead and release. Later we can actually remove the function and switch to using scran::clusterCells().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants