Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renv & python #242

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update renv & python #242

merged 3 commits into from
Nov 27, 2023

Conversation

jashapiro
Copy link
Member

@jashapiro jashapiro commented Nov 22, 2023

Since I was already messing around with versions, I thought I would see what happened if I tried updating more packages. I don't think we should put this in as part of 0.3.1, because it needs more QC to be sure, but maybe we could see.

Note that I did not update Bioconductor as part of this PR, only packages within Bioconductor 3.17 and from CRAN

The main advantage of the updating, by the way, is that a lot of annoying warnings are removed due to changes in how sparse matrices are stored. I also close a few of dependabot's security warnings with python packages.

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, we are having some issues with what appears to be Matrix, we're going to go ahead and get this in to test. So I'm going ahead and approving.

@jashapiro jashapiro marked this pull request as ready for review November 27, 2023 15:07
@jashapiro
Copy link
Member Author

I guess we should try it? @allyhawkins

@jashapiro jashapiro merged commit 4a063ff into main Nov 27, 2023
2 checks passed
@jashapiro jashapiro deleted the jashapiro/update-packages branch May 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants