Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compression in sce_to_anndata() #244

Closed
jashapiro opened this issue Dec 12, 2023 · 1 comment · Fixed by #246
Closed

Support compression in sce_to_anndata() #244

jashapiro opened this issue Dec 12, 2023 · 1 comment · Fixed by #246
Assignees

Comments

@jashapiro
Copy link
Member

Is your feature request related to a problem? Please describe.

We currently write out AnnData files without any compression. We should pass arguments for compression to zellkonverter::writeH5AD()

Describe the solution you'd like

We can add a ... to the call that passes any additional arguments down to zellkonverter::writeH5AD

Describe alternatives you've considered

We could add a add a compression argument that we pass directly to the compression argument, rather than the catchall, but I like the fact that this gives us free support for other writeH5AD() options.

@jashapiro
Copy link
Member Author

We should also allow .h5ad as a file extension for this function, since that seems to be the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants