Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider union of genes when merging, not intersection #249

Open
sjspielman opened this issue Dec 18, 2023 · 1 comment
Open

Consider union of genes when merging, not intersection #249

sjspielman opened this issue Dec 18, 2023 · 1 comment

Comments

@sjspielman
Copy link
Member

In the current code to merge SCE objects, we subset all SCEs (the RNA experiments, specifically) to only include the intersection of genes in the final merged object. We may want to expand this to instead consider the union of genes. A PR for that was started here, and we'll circle back to it (there will probably be some fun code conflicts, but we'll want to keep the code and comments for future use) - #247
Direct link to branch - https://github.com/AlexsLemonade/scpcaTools/tree/sjspielman/150-union-of-features

@sjspielman
Copy link
Member Author

Noting, as mentioned #247 (comment), we're very unlikely to do this ever. Keeping the issue open for now, but it may be worth just closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant