Update help.js #11
Open
Update help.js #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the module.exports: permissions = [], is defined and by default the permission check uses let permissions = command.permission which is not used in the add or add-economy command. This leads to all commands being shown for all users irrespective of their actual permissions. Changed permissions to commandPermissions to be prevent overlap with existing variable and to be less ambiguous & to function as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let permissions = command.permissionWill cause this to always display all commands, regardless of the permissions of the user, irrespective of their actual permissions as both the add command, add currency command + the default module.exports use the key value pair labelled "permissions" not permission. Changing to be
let commandPermissions = command.permissionsresolves this by pulling the correct key/value pair and as such commands will not be shown if the user doesn't have the permissions.