Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Please demonstrate how to switch versions of artifacts via environment/config #102

Open
binduwavell opened this issue Oct 30, 2024 · 2 comments

Comments

@binduwavell
Copy link
Contributor

Obviously we can edit the artifacts.json files. It would be great if there is a way to specify versions for repo/share/tomcat/etc all using common environment variables that are used for things like selecting edition.

@gionn
Copy link
Member

gionn commented Nov 5, 2024

The main idea on the roadmap is that we maintain a matrix of artifacts compatible with each supported alfresco version and easily switch between them (internally tracked as OPSEXP-2849).

As of now you can edit any artifacts.json as you figured out, then the quickest way is to run ./scripts/clean-artifacts.sh && ./scripts/fetch-artifacts.sh which will cleanup every archives from the docker build directories and then fetching all the artifacts again - eventually leveraging already downloaded artifacts present in the artifacts_cache folder.

@binduwavell
Copy link
Contributor Author

Thank you.

I suspect that clean-artifacts.sh could do with a little love. The strategy of just searching for certain file extensions without using the artifacts.json files seems a little brittle but OK. However the last line that uses xargs to rm seems very dangerous. I believe that can have dangerous consequences if there are spaces in paths. You are probably safer using -exec arguments to find or using -print0 on find and -0 on xargs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants