OPSEXP-2719: Wrap image creation with make #17

alxgomz · 2024-07-31T07:41:58Z

Ref: OPSEXP-2719

README.md

scripts/fetch-artifacts.sh

Makefile

.github/workflows/build_and_test.yml

pmacius · 2024-08-20T09:50:04Z

helm/helm#12879
helm/helm#12637

.github/workflows/build_and_test.yml

.github/workflows/test-make.yml

alxgomz requested review from pmacius and gionn and removed request for pmacius July 31, 2024 08:21

pmacius reviewed Jul 31, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

alxgomz requested a review from pmacius July 31, 2024 09:22

gionn reviewed Jul 31, 2024

View reviewed changes

scripts/fetch-artifacts.sh Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

alxgomz requested a review from gionn July 31, 2024 10:58

gionn requested changes Jul 31, 2024

View reviewed changes

.github/workflows/build_and_test.yml Show resolved Hide resolved

alxgomz requested a review from gionn July 31, 2024 12:53

pmacius previously approved these changes Jul 31, 2024

View reviewed changes

alxgomz force-pushed the OPSEXP-2719 branch from e6106b1 to 8193331 Compare July 31, 2024 15:51

gionn approved these changes Aug 1, 2024

View reviewed changes

alxgomz dismissed pmacius’s stale review via 0e71306 August 1, 2024 08:40

gionn requested changes Aug 1, 2024

View reviewed changes

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved

alxgomz added 11 commits August 2, 2024 11:09

ignore OS packages

f82d0c0

allow fetching artifacts for a subset of targets only

252c010

add make wrapper and initial doc

2528f67

fixup

cf2006f

remove gitignore dup

7d0d0bf

ignore and cleanup more archive types

e2aee05

gitignore cleanup

d005260

review comment

f06a402

review comment

01ecd17

review comment

de253da

test Makefile independently

dea2dd7

alxgomz force-pushed the OPSEXP-2719 branch from 0e71306 to dea2dd7 Compare August 2, 2024 11:06

alxgomz requested review from gionn and pmacius August 2, 2024 16:36

gionn removed their request for review August 5, 2024 13:02

pmacius added 20 commits August 13, 2024 16:55

fix

99fc99c

revert name of step

3706297

free disk space

6f60eb6

add missing connectors inside make

cf733db

skip checking the artfiacts

99b97f9

skip checking the artfiacts

4fbbbc6

fix

5ae293f

add missing prepare connectors step

40bce95

test

6451c67

rebase

051fbef

try different type of overriding probes

9c3a898

test the workaround

ba90802

try different approach

b4d3583

test

938339a

test alpha

cc3ebe1

disable different way

85e99e3

try ussing set

9666e5e

try ussing set

2cd5abc

Remove connectors - will be tested on tf-pipeline

a2a8a5c

remove outputs

2adc3fd

pmacius requested a review from gionn August 20, 2024 08:44

pmacius marked this pull request as ready for review August 20, 2024 08:44

gionn requested changes Aug 20, 2024

View reviewed changes

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved

Review comments

b0c6b16

gionn requested changes Aug 20, 2024

View reviewed changes

.github/workflows/test-make.yml Show resolved Hide resolved

uniform

7f4deaf

gionn approved these changes Aug 20, 2024

View reviewed changes

pmacius merged commit 656c28a into main Aug 20, 2024
5 checks passed

pmacius deleted the OPSEXP-2719 branch August 20, 2024 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OPSEXP-2719: Wrap image creation with make #17

OPSEXP-2719: Wrap image creation with make #17

alxgomz commented Jul 31, 2024

pmacius commented Aug 20, 2024

OPSEXP-2719: Wrap image creation with make #17

OPSEXP-2719: Wrap image creation with make #17

Conversation

alxgomz commented Jul 31, 2024

pmacius commented Aug 20, 2024