Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources limits for connectors #36

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Add resources limits for connectors #36

merged 4 commits into from
Aug 19, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented Aug 19, 2024

No description provided.

@pmacius pmacius requested review from gionn and alxgomz August 19, 2024 08:14
@pmacius pmacius marked this pull request as ready for review August 19, 2024 08:14
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess cpu limit can be 2 overall for every deployment (hosted runners has 2 cores)

test/helm/test-overrides.yaml Outdated Show resolved Hide resolved
test/helm/test-overrides.yaml Outdated Show resolved Hide resolved
Co-authored-by: Giovanni Toraldo <[email protected]>
@pmacius pmacius requested a review from gionn August 19, 2024 08:45
gionn
gionn previously approved these changes Aug 19, 2024
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set also replicaCount 1 - it's spawning 2 pods for each connector

@pmacius pmacius merged commit d24899a into main Aug 19, 2024
4 checks passed
@pmacius pmacius deleted the ms365-fix branch August 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants