From dbdfbbfb70d4562e661895eca5c29f168e94de3e Mon Sep 17 00:00:00 2001 From: pmacius Date: Mon, 19 Aug 2024 09:51:25 +0200 Subject: [PATCH 1/4] Add resources limits for connectors --- test/helm/test-overrides.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/test/helm/test-overrides.yaml b/test/helm/test-overrides.yaml index 64ad0c3e..3a7b8593 100644 --- a/test/helm/test-overrides.yaml +++ b/test/helm/test-overrides.yaml @@ -57,6 +57,13 @@ alfresco-connector-ms365: ALFRESCO_ADMIN_PASSWORD: admin ALFRESCO_ADMIN_USERNAME: admin livenessProbe: null + resources: + requests: + cpu: "0.01" + memory: "256Mi" + limits: + cpu: "1" + memory: "512Mi" alfresco-connector-msteams: enabled: true image: @@ -67,6 +74,13 @@ alfresco-connector-msteams: app: id: admin password: admin + resources: + requests: + cpu: "0.01" + memory: "256Mi" + limits: + cpu: "1" + memory: "512Mi" dtas: additionalArgs: - --tb=short From 2795a188a486cb25e3bebb1d9831e1c4caf6d266 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Maciusiak?= <158472457+pmacius@users.noreply.github.com> Date: Mon, 19 Aug 2024 10:29:21 +0200 Subject: [PATCH 2/4] Apply suggestions from code review Co-authored-by: Giovanni Toraldo <71768+gionn@users.noreply.github.com> --- test/helm/test-overrides.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/helm/test-overrides.yaml b/test/helm/test-overrides.yaml index 3a7b8593..d4685227 100644 --- a/test/helm/test-overrides.yaml +++ b/test/helm/test-overrides.yaml @@ -62,7 +62,7 @@ alfresco-connector-ms365: cpu: "0.01" memory: "256Mi" limits: - cpu: "1" + cpu: "2" memory: "512Mi" alfresco-connector-msteams: enabled: true @@ -79,7 +79,7 @@ alfresco-connector-msteams: cpu: "0.01" memory: "256Mi" limits: - cpu: "1" + cpu: "2" memory: "512Mi" dtas: additionalArgs: From 1fdce036432b215abafb719b1b2591770491f6b7 Mon Sep 17 00:00:00 2001 From: pmacius Date: Mon, 19 Aug 2024 10:54:46 +0200 Subject: [PATCH 3/4] fix --- .github/workflows/build_and_test.yml | 2 +- test/helm/test-overrides.yaml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index e3d2d683..dcea13a2 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -183,7 +183,7 @@ jobs: - name: Watch Helm deployment env: - HELM_INSTALL_TIMEOUT: 8m + HELM_INSTALL_TIMEOUT: 10m run: | kubectl get pods --watch & KWPID=$! diff --git a/test/helm/test-overrides.yaml b/test/helm/test-overrides.yaml index d4685227..e057399e 100644 --- a/test/helm/test-overrides.yaml +++ b/test/helm/test-overrides.yaml @@ -69,6 +69,8 @@ alfresco-connector-msteams: image: repository: localhost/alfresco-ms-teams-service tag: latest + readinessProbe: + initialDelaySeconds: 120 livenessProbe: null microsoft: app: From a17791f775843ec4f71075c893c7211b1bfb22d2 Mon Sep 17 00:00:00 2001 From: pmacius Date: Mon, 19 Aug 2024 11:05:02 +0200 Subject: [PATCH 4/4] add replicas --- test/helm/test-overrides.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/helm/test-overrides.yaml b/test/helm/test-overrides.yaml index e057399e..38d35585 100644 --- a/test/helm/test-overrides.yaml +++ b/test/helm/test-overrides.yaml @@ -50,6 +50,7 @@ alfresco-transform-service: #alfresco-sync-service: alfresco-connector-ms365: enabled: true + replicaCount: 1 image: repository: localhost/alfresco-ooi-service tag: latest @@ -66,6 +67,7 @@ alfresco-connector-ms365: memory: "512Mi" alfresco-connector-msteams: enabled: true + replicaCount: 1 image: repository: localhost/alfresco-ms-teams-service tag: latest