[ACS-9010] Loading spinner is not shown on search results page when filtering for files or folders #10434
Conversation
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
changed the title
dominikiwanekhyland
force-pushed
the
ACS-8898-empty-context-menu-on-multi-selected-libraries
branch
from
432f609
to
cf37315
Compare
| @@ -596,6 +596,7 @@ export abstract class BaseQueryBuilderService { | |||
| * @param searchUrl search url to navigate to | |||
| */ | |||
| async navigateToSearch(query: string, searchUrl: string) { | |||
| this.update(); | |||
There was a problem hiding this comment.
This line was previously here but I removed it as it was introducing another bug, with it the search execution will be called twice causing some errors in various situations, for example if you search for 'test' you will get the results but then after searching for zxcv even though you should not get any results you will get the 'old' search results from previous query, that's why I think we need to find some other solution for this bug
|
| @@ -68,8 +68,6 @@ export class SearchFacetFiltersService { | |||
| this.responseFacets = null; | |||
| }); | |||
|
|
|||
| this.queryBuilder.updated.pipe(takeUntilDestroyed()).subscribe((query) => this.queryBuilder.execute(true, query)); | |||
There was a problem hiding this comment.
With this change when you change the state of any filter and click apply it won't trigger any search request
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-9010
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: