-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmarks don't work at all #103
Comments
Maybe we should get rid of this feature? I mean, we already have a browser 2014-05-10 0:43 GMT-03:00 metazoxan [email protected]:
Fábio de Godoy |
The thing I always liked about bookmarks though is I could save my progress with a manga and not have it red all the time. For example lets take Hayate the Combat butler. I'm no where near up to the latest chapter with that. but I don't want it to sit at the top of the list as a red one all the time. Besides that if for any reason I decide to stop reading a specific manga for a while I can leave the last read chapter in my bookmarks. Plus there were times that leaving notes on a bookmark was convenient. So I'd prefer is AMR had at least some kinda feature with a similar function. |
There is a bookmark API just that it wouldn't work on specific scans (well, it can, but will be just links to the raw jpg). I'm going to disable the feature everywhere in the mean time (with a switch of course) so people can focus on other things. What everyone thinks? |
BTW, the bookmark.js file is a holy mess https://codeclimate.com/github/AllMangasReader-dev/AMR/js/bookmarks.js, so I wouldn't want to tangle myself with it. |
I suposse I could use a custom category. I just always kinda liked being able to simply click the little star to save my place. |
We could not put the categories in the manga reading toolbar? That would 2014-05-10 14:28 GMT-03:00 metazoxan [email protected]:
Fábio de Godoy |
That does sound interesting. At the very least it's certainly worth a try especially if the bookmark system is such a mess. Maybe Bookmarks could also be included as one of the native Categories. Also while we're on this subject is a category is striked through (meaning ti's excluded from the list) do update notifications still show up normally? I haven't used categories too much so I'm not sure and I didn't see this mentioned in the FAQ. |
braiam keeps saying to try posting issues on GitHub so I'm giving it a try.
Anyway the problem is the Bookmarks are all messed up. Sometimes when I try to get rid of one it won't go away or it deletes the one above it instead and whenever I click on a bookmark it goes to whatever is on the bottom of the list instead. For example I have a chapter of Zettai Karen Children at the bottom of my bookmark list. No matter what link I click on it goes to that chapter of Zettai Karen Children.
The text was updated successfully, but these errors were encountered: