Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate WebSQL to IndexedDB #81

Open
braiam opened this issue Jul 11, 2013 · 4 comments
Open

Migrate WebSQL to IndexedDB #81

braiam opened this issue Jul 11, 2013 · 4 comments

Comments

@braiam
Copy link
Member

braiam commented Jul 11, 2013

Heya, how's life? For me is pretty dark... I just get a wind that WebSQL is being dropped some day... and we have to move ourself to update our stuff... I had read this but haven't made nor head nor tails how we can adapt our code since @plduhoux made a custom library for webSQL.

So I would love some rope to get this done... ah, btw, I haven't figure out how to create a darn DB using that guide, anyone can explain to me in a way a 4-years-old can understand? I've used more generic guides but I need some translator to help me understand the armcsql.js file.

ADD: The only things that use WebSQL are:

  • Manga/chapter lists for sites that only have full list but not search function.
  • The personal statistic.
  • The implementations data.
@braiam
Copy link
Member Author

braiam commented Jul 11, 2013

Ah, btw, we could break down this bug into several steps like:

  1. Create our library that will replace the amrcsql.js file.
  2. Make the functions that will migrate the already done stuff smoothly. (Here we should release a stable version)
  3. Hunt down all the old functions in background page and replace them.
  4. Verify everything works for old and new installations. (Another release here)
  5. Cleanup the code (delete old library, delete old database).

Any troughs?

@bessx
Copy link
Member

bessx commented Jul 11, 2013

though it's true it'll be killed, it's really not a problem. we can js
store it in google drive for now.
it's not that difficult, and it'll auto-sync a lot better than bookmarks.
check out this app:

https://chrome.google.com/webstore/detail/ouistiti/hkbgpehljlmbjlgalhcpnlcljaodmaaf

Code here:

https://drive.google.com/folderview?id=0B8R1QvA3x5IbVWtfVTRma1NVNms#list

We can work on upgrading the code later.

-- Adam Bess

On Wed, Jul 10, 2013 at 10:52 PM, Braiam Peguero
[email protected]:

Ah, btw, we could break down this bug into several steps like:

  1. Create our library that will replace the amrcsql.js file.
  2. Make the functions that will migrate the already done stuff
    smoothly. (Here we should release a stable version)
  3. Hunt down all the old functions in background page and replace them.
  4. Verify everything works for old and new installations. (Another
    release here)
  5. Cleanup the code (delete old library, delete old database).

Any troughs?


Reply to this email directly or view it on GitHubhttps://github.com//issues/81#issuecomment-20788930
.

@braiam
Copy link
Member Author

braiam commented Jul 15, 2013

Sorry, but you lost me there. You mean using google drive for our async databases operations? You know that those calls are limited by min/usage and space? We will get blocked several times or the latency will kill us. Also, how should we store a database as file? In CSV? I don't know how much you love that API, but for our current specifications and characteristic I don't see any use. Maybe any of the @AllMangasReader-dev/developers may differ of my opinion, please give us some update.

On a side note: ouistiti is mainly for demostrate the notification api, maybe we can fire up some test in the lab since it uses the button characteristic.

@fuzetsu
Copy link
Contributor

fuzetsu commented Jul 15, 2013

If the API was available to use (it's only for chrome apps, not extensions)
then it would definitely be handy for handling the syncing issue. But as it
is it won't help with the database issue. I've never had a chance to play
with IndexedDB so I can't really comment on that (I'll see if I can look at
it sometime soon).

I haven't looked at the custom library either but if the currently
implemented concepts aren't too different from the indexedDB concepts it
might make it easier to convert over because we can just adjust the library
without actually having to change the calls in the normal code.

On Mon, Jul 15, 2013 at 12:55 AM, Braiam Peguero
[email protected]:

Sorry, but you lost me there. You mean using google drive for our async
databases operations? You know that those calls are limited by min/usage
and space? We will get blocked several times or the latency will kill us.
Also, how should we store a database as file? In CSV? I don't know how much
you love that API, but for our current specifications and characteristic I
don't see any use. Maybe any of the @AllMangasReader-dev/developers may
differ of my opinion, please give us some update.

On a side note: ouistiti is mainly for demostrate the notification api,
maybe we can fire up some test in the lab since it uses the buttoncharacteristic.


Reply to this email directly or view it on GitHubhttps://github.com//issues/81#issuecomment-20951787
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants