code cleanup

AllMightySauron · Nov 26, 2020 · 7f93aa2 · 7f93aa2
1 parent 1c6f5bd
commit 7f93aa2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "swgoh-api-swgohgg",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "SWGoH helper API for swgoh.gg",
   "main": "index.js",
   "keywords": [

diff --git a/swgohgg-api.js b/swgohgg-api.js
@@ -575,16 +575,9 @@ class SwgohGGApi {
     static getPlayerUnitFromUnits(player, searchName) {
         var result;
 
-        // loop over characters
-        for (var i = 0; i < player.units.length; i++) {
-            const unit = player.units[i].data;
+        const playerUnit = player.units.find(unit => unit.data.name.toLowerCase() == searchName.toLowerCase());
 
-            // test for name (ignoring case)
-            if (unit.name.toLowerCase() == searchName.toLowerCase()) {
-                result = unit;
-                break;
-            }
-        }
+        if (playerUnit) result = playerUnit.data;
 
         return result;
     }