better handling for dummy data on player roster

AllMightySauron · Apr 16, 2021 · c0dab1e · c0dab1e
1 parent 332926e
commit c0dab1e
Show file tree

Hide file tree

Showing 5 changed files with 18,660 additions and 13,304 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "swgoh-api-swgohhelp",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "SWGoH helper API for swgoh.help",
   "main": "index.js",
   "keywords": [

diff --git a/swgohhelp-api.js b/swgohhelp-api.js
@@ -570,7 +570,7 @@ class SwgohHelpApi {
      * @returns {Unit} The unit from player roster.
      */
     static getPlayerUnitFromUnits(player, searchName) {
-        return player.roster.find(unit => unit.nameKey.toLowerCase() == searchName.toLowerCase());
+        return player.roster.filter(unit => unit.nameKey != null).find(unit => unit.nameKey.toLowerCase() == searchName.toLowerCase());
     }
 
     /**