Lightweight themes not applied when Findbar (NoScript etc?) opened

[nmaier]

Steps:

1. Install a lightweight theme, aka. Persona
2. Observe the addon-bar, with our without Barlesque is styles according to the lightweight theme (footer image) as it is part of bottomBox.
3. Configure Barlesque to stack the addon-bar above the FindBar (or any other bar I guess); IIRC findmode=2
4. Open the FindBar
5. The Barlesque addon-bar loses the lightweight theme style

The behaviour is due Barleque:

1. The styles Barlesque adds in this case (the background gets grey)
2. The fixed position above the addon-bar moves it outside of the area that the bottom-box and hence outside of the area that is covered by the lightweight theme background-image.

I'm not quite sure how to remedy this. Brainstorming, I come up with these ideas:

• Listen for lightweight theme styling changes and apply the background image yourself.
• Never apply lightweight theme images
• Move the addon-bar element above the FindBar and drop the position fixed.

[Drugoy]

Yeah, there will definitely be some problems with personas, since they may change toolbars' heights.
But fixing the gray background might be possible, I just suggested a style with the hardcoded color as I don't use any themes and forgot to think about possible compatibility problems with them.
The problem is that if we detach add-on bar it's background becomes completely transparent.
We can try to remove "!important" from that rule and hope that persona's style has "important" so it will have more priority.
Or try to remove the hardcoded colors and try to reach the effect of non-transparent background by using -moz-appearance.

[AllSeeingEye]

But fixing the gray background might be possible

background-color: transparent !important; background-image: none;

• this css rule makes add-on bar that is overlaid over the find bar "compatible" with personas. For other use cases, we'll need to play with "inherit", I think.

Targetting this for v1.16.

[AllSeeingEye]

Listen for lightweight theme styling changes and apply the background image yourself.

I've tested some personas, and most seem to apply some background to #bottom-box element - probably we should just copy it.

[nmaier]

I've tested some personas, and most seem to apply some background to #bottom-box element - probably we should just copy it.

Indeed, but don't forget about the foreground color. ;)
Best would be to observe the "lightweight-theme-styling-update" notification. See/steal from:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/LightweightThemeConsumer.jsm

[Drugoy]

Oh, I forgot about an easy and proper fix.
All we need is just to add :not(-moz-lwtheme) to the elements we apply background changes.

[Drugoy]

Try this version and tell me if the issue has gone for you: http://dl.dropbox.com/u/11652751/barlesque-1.15-fx.xpi

[Drugoy]

Oh, this makes a transparent background for the addon-bar if no theme/persona is installed, so I'll investigate this problem a little bit more, but tomorrow.

For some reason the rule .barlesque-bar:not(:-moz-lwtheme)
{ background-color: -moz-dialog !important;}
appears to be invalid.

[AllSeeingEye]

For some reason the rule .barlesque-bar:not(:-moz-lwtheme)
{ background-color: -moz-dialog !important;} appears to be invalid.

Yes - that's because background-color is applied to #addon-bar, not to .barlesque-bar (which is always a #bottom-box).

[Drugoy]

no, it's because in 1 of the lines I had a typo and forgot to add just 1 symbol. Now it's fixed.
same link http://dl.dropbox.com/u/11652751/barlesque-1.15-fx.xpi

[Drugoy]

http://dl.dropbox.com/u/11652751/barlesque-1.15b-fx.xpi this is a version that works properly with skins.

[ghost]

@Drugoy or AllSeeingEye: Is the above version which "works properly with skins" still available? The link in the previous comment is broken. Could you post a more permanent link to the file? Much appreciated. Thank You All!

[Drugoy]

Sorry, seems like I've removed this file and I don't have any copies of it.
I don't use barlesque anymore, since the author stopped developing it.
You may try this add-on instead: https://addons.mozilla.org/en-US/firefox/addon/minimize-addon-bar/

[ghost]

Greetings Drugoy,

I was afraid of this...Thank You for the immediate response.
I just tried out your suggested alternative. While it does allow me to alter the color of the Add-on Bar (including reducing alpha transparency to a minimum value of 10!), it completely changes the position and style of the Find Bar without even an option to decline these changes. This is much less desirable than using Barlesque, which, with "overlaid" mode turned on, essentially provides the look of a combined Find Bar and Add-on Bar. Even if Minimize Addon-Bar was updated with an option to decline changes to the Find Bar and overlay it instead, there is another issue: unlike Barlesque, Minimize Addon-Bar displays two of the icons I have chosen for the Add-on Bar lower than the rest, resulting in an undesirable visual effect.

Perhaps if you're not too busy, you could post some instruction on what one would need to do to achieve the same fix for Barlesque as you made earlier, where Personas properly display through the Add-on Bar. I'm sure it would be useful reference material for anyone experiencing a similar situation. Judging by the previous posts on this page, it seems like a simple matter of adding a few lines of code to a particular file, but I'm unsure what to insert into which file. Thank You :)