Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Apotheosis "Ancient Knowledge" Effect Timers not working #1892

Open
KindarConrath opened this issue Jan 19, 2025 · 2 comments
Open

[Bug]: Apotheosis "Ancient Knowledge" Effect Timers not working #1892

KindarConrath opened this issue Jan 19, 2025 · 2 comments
Labels
Bug Something isn't working Mod Bug Issue within or caused by a mod Reported to Mod Dev This issue has been reported to the mod dev

Comments

@KindarConrath
Copy link

KindarConrath commented Jan 19, 2025

Possible Fixes

Yes

Modpack Version

2.25

What happened?

Issue:
Ancient Knowledge isn't refreshing or stacking as it was before the last update.

Steps to reproduce:
Create SP world (in creative)
give sword, reforging table, godforged pearls, augmenting table
place down reforging table
put sword & godforged pearls in reforging table
enchant sword without modifier "On hit, gain Ancient Knowledge () [] [Stacking]"
swap a yellow text property for the Ancient Knowledge modifier
** the one you usually get from strait enchanting is "Sophisticated" which is the really long duration one, you want "Omniscient" which has a short duration/cooldown, you usually have to get this one from reforging **
give Target Dummy
place down Target Dummy
hit with sword
check that you have Ancient Knowledge
wait the cooldown duration
hit the dummy again
check Ancient Knowledge

Expected behaviour:
refresh cooldown & stack Ancient Knowledge

Current behaviour:
cooldown doesn't refresh until the duration remaining is under 10 seconds, and it may or may not stack to IV but never higher

Previous behaviour:
cooldown refreshed and Ancient Knowledge stacked infinitely, adding stacks on after each cooldown period

From pack version 2.18
Image

Current pack version 2.25

Image

latest.log

No response

Developer reports

No response

@KindarConrath KindarConrath added the Bug Something isn't working label Jan 19, 2025
@Pomaranczowy66
Copy link

Intended fix for this exact behavior
https://github.com/Shadows-of-Fire/Apotheosis/blob/1.21/changelog.md#812

@TheBedrockMaster TheBedrockMaster added Reported to Mod Dev This issue has been reported to the mod dev Mod Bug Issue within or caused by a mod labels Jan 20, 2025
@KindarConrath
Copy link
Author

KindarConrath commented Jan 20, 2025

Hmm, according to that, the change was intended.
though

  1. the re-application after CD timer is pretty broken
  2. it is unfortunate that very high XP requirements for improving gear were added (see 225 level cost for upgrade - per step) while taking away the best way to get XP

@TheBedrockMaster TheBedrockMaster added Bug Something isn't working Reported to Mod Dev This issue has been reported to the mod dev Mod Bug Issue within or caused by a mod and removed Bug Something isn't working Reported to Mod Dev This issue has been reported to the mod dev Mod Bug Issue within or caused by a mod labels Jan 20, 2025
@TheBedrockMaster TheBedrockMaster changed the title [Bug]: Apotheosis Modifier "Ancient Knowledge" not stacking correctly [Bug]: Apotheosis "Ancient Knowledge" Effect Timers not working Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Mod Bug Issue within or caused by a mod Reported to Mod Dev This issue has been reported to the mod dev
Projects
None yet
Development

No branches or pull requests

3 participants