Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ophys analysis functions robust to lack of cell_specimen_id #7

Open
matchings opened this issue Sep 15, 2022 · 0 comments
Open

Comments

@matchings
Copy link
Collaborator

Experiments that are not part of an ophys container or do not have cell matching run on them for whatever reason will not have values for cell_specimen_id (they will be NaN). This breaks several functions that expect the cell_specimen_id column, including build_tidy_cell_df.

We need to add some functionality either defaults to use cell_roi_id when cell_specimen_id is not present, or replaces the values of cell_specimen_id column with the values of cell_roi_id to ensure that subsequent functions can run.

The former solution is probably preferable in terms of explicitness (i.e. you know for sure that cell_roi_id was used, but likely requires more extensive intervention into the code.

@matchings matchings changed the title Make tidy_cell_df and other functions robust to lack of cell_specimen_id Make ophys analysis functions robust to lack of cell_specimen_id Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant