Make ConnectionError.Failed not log. #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing the real reason for this issue happening now is that Discord still has an IPC file despite not running. However, since there's no non-brittle way to know if Discord is actually running, and KDiscordIPC doesn't let us know why the connection failed, I figure the next best thing is just to not make the user know about it.
The drawback is that if there's an actual problem preventing the rich presence from activating, the only way to know is to let the user discover it themselves by looking at their Discord instance.
Fixes #396 by hiding it. Not my favorite solution, but it's not reporting a problem to begin with.