Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use actual localization for birth date input? #81

Open
ghbrown opened this issue Sep 2, 2024 · 2 comments
Open

[BUG] Use actual localization for birth date input? #81

ghbrown opened this issue Sep 2, 2024 · 2 comments

Comments

@ghbrown
Copy link

ghbrown commented Sep 2, 2024

The localization for the date of birth (DOB) on the registration screen can only be one of two options (de or en-GB).
I wasn't paying much attention and tried to use MM/DD/YYYY, and was surprised when the date changed with no explanation.

To Reproduce

  • go to Alovoa and try to register with email
  • try to enter a MM/DD/YYYY format date and watch it change (e.g. 08/30/2000 -> 08/08/2001 on last keystroke)

Expected behavior

The date format should respect the actual localization, here en-US would suffice for me.

Web application

(though I suspect iOS and Android are affected too)

  • Firefox 129

Proposed fix

This fix works locally for the web version, but I can't guarantee much more than that.
I'm sure this is/was related to the only two translations being de and en, but this is the only place in the code I've found something like this being done and I don't immediately see how this change would break things.

If this fix is acceptable I am happy to make a PR.

@Nonononoki
Copy link
Contributor

The locale is limited to de and en right now because those are the supported languages.

@ghbrown
Copy link
Author

ghbrown commented Sep 19, 2024

The fact that MM/DD/YYYY is impossible for en-US even though English is a supported language seems like a bug. My proposal is one way to address this, but another approach may be preferable.

My proposed fix should allow date input in any localization, even if their local language is not supported by an internationalization file since this change only affects the date picker. I don't see any real downsides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants