Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divider to Likert #2765

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add divider to Likert #2765

wants to merge 3 commits into from

Conversation

tina-ahm
Copy link
Contributor

@tina-ahm tina-ahm commented Nov 28, 2024 •
edited
Loading

Description

  • Adds the option to have a divider between the answer columns of the Likert component.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@Magnusrm Magnusrm added the kind/product-feature Pull requests containing new features label Nov 28, 2024
@tina-ahm tina-ahm marked this pull request as ready for review November 29, 2024 07:51
@elwal elwal added the org/ssb Issues relevant for Statistisk sentralbyrå. label Nov 29, 2024
olemartinorg
olemartinorg approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌 I think @Magnusrm was also looking into this and wanted to add some tests? 🙏

src/layout/LikertItem/LikertItemComponent.tsx Outdated Show resolved Hide resolved
src/codegen/Common.ts Outdated Show resolved Hide resolved
@tina-ahm
Update LikertItemComponent.tsx
44e247c 
- Update so it picks the column value directly
@tina-ahm
Combine 'addLeftDivider' & 'addRightDivider' props
3df91fc 
- Combine 'addLeftDivider' & 'addRightDivider' props into 'divider'
- Change CSS border property to 'border-inline-start/end' in order to support RTL languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemartinorg olemartinorg olemartinorg approved these changes

Assignees

@Magnusrm Magnusrm

@tina-ahm tina-ahm

Labels
kind/product-feature Pull requests containing new features org/ssb Issues relevant for Statistisk sentralbyrå.
Projects
Prosjekt Team-Apps-Migration
Status: Review
Team Apps
Status: 🔎 Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Likert with a divider
4 participants
@tina-ahm @olemartinorg @elwal @Magnusrm