Cleanup analyzers and StyleCop config, enable builtint .NET static an…

…alysis (#641)
Altinn · May 14, 2024 · d228eaf · d228eaf
1 parent e60b72c
commit d228eaf
Show file tree

Hide file tree

Showing 42 changed files with 140 additions and 654 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -73,7 +73,6 @@ max_line_length = 160
 end_of_line = crlf
 dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
 
-[*.cs]
 csharp_using_directive_placement = outside_namespace:silent
 csharp_prefer_simple_using_statement = true:suggestion
 csharp_prefer_braces = true:silent
@@ -91,6 +90,18 @@ csharp_style_expression_bodied_local_functions = false:silent
 csharp_indent_labels = one_less_than_current
 csharp_style_prefer_primary_constructors = false:suggestion
 
+# CA1848: Use the LoggerMessage delegates
+dotnet_diagnostic.CA1848.severity = none
+
+# CA1727: Use PascalCase for named placeholders
+dotnet_diagnostic.CA1727.severity = suggestion
+
+# CA2254: Template should be a static expression
+dotnet_diagnostic.CA2254.severity = none
+
+# CA1822: Mark members as static
+dotnet_diagnostic.CA1822.severity = suggestion
+
 [Program.cs]
 dotnet_diagnostic.CA1050.severity = none
 dotnet_diagnostic.S1118.severity = none
diff --git a/Altinn3.ruleset b/Altinn3.ruleset
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -5,6 +5,10 @@
 
     <PropertyGroup>
         <LangVersion>latest</LangVersion>
+        <EnableNETAnalyzers>true</EnableNETAnalyzers>
+        <AnalysisMode>Minimum</AnalysisMode>
+        <Features>strict</Features>
+        <!-- <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors> -->
     </PropertyGroup>
 
     <ItemGroup>