Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the full data model to app-frontend after processing a write operation #316

Closed
Tracked by #1660
olemartinorg opened this issue Sep 25, 2023 · 1 comment
Closed
Tracked by #1660

Return the full data model to app-frontend after processing a write operation #316

olemartinorg opened this issue Sep 25, 2023 · 1 comment
Assignees
@RonnyB71
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes fe-v4 Issues required for app-frontend v4 to be shippable kind/feature-request New feature or request
Milestone
8.0.0

Comments

@olemartinorg
Copy link
Contributor

Description

Instead of diffing the data model for changes and returning those changes to app-frontend, the backend should just return the full data model as-is.

This could also include:

  • Removing data not present in the strict model
  • Any changes from ProcessDataWrite

And has the advantage of:

  • Removing JsonHelper altogether
  • Simplifying logic when saving data on the backend, and shifting this responsibility to the frontend instead

Additional Information
@olemartinorg olemartinorg added kind/feature-request New feature or request breaking-change Label Pull requests with breaking changes. Used when generating releasenotes status/triage labels Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Sep 25, 2023
Closed
@olemartinorg olemartinorg added the fe-v4 Issues required for app-frontend v4 to be shippable label Sep 25, 2023
@tjololo tjololo added this to the 8.0.0 milestone Sep 26, 2023
@olemartinorg olemartinorg mentioned this issue Oct 2, 2023
Closed
12 tasks
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
@olemartinorg olemartinorg mentioned this issue Nov 29, 2023
Merged
5 tasks
@RonnyB71 RonnyB71 moved this to 📈 Todo in Team Apps Jan 2, 2024
@olemartinorg olemartinorg moved this from 📈 Todo to 🧪 Test in Team Apps Jan 24, 2024
@olemartinorg
Copy link
Contributor Author

Fixed as of #393

@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyB71 RonnyB71

Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes fe-v4 Issues required for app-frontend v4 to be shippable kind/feature-request New feature or request
Projects
Team Apps
Archived in project
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@olemartinorg @tjololo @RonnyB71