Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data models changed from earlier releases #884

Closed
olemartinorg opened this issue Nov 5, 2024 · 2 comments
Closed

Data models changed from earlier releases #884

olemartinorg opened this issue Nov 5, 2024 · 2 comments
Labels
kind/bug Something isn't working status/triage

Comments

@olemartinorg
Copy link
Contributor

Description of the bug

In the ttd/frontend-test app, some (untouched?) data model fields suddenly changed when using a newer version of app-lib-dotnet. This was an unexpected/breaking change.

Image

Steps To Reproduce

  1. Switch to use project references in ttd/frontend-test, and point them to the latest main branch in app-lib-dotnet
  2. Run the end-to-end test in app-frontend called all-process-steps

Additional Information

@olemartinorg olemartinorg added the kind/bug Something isn't working label Nov 5, 2024
@olemartinorg
Copy link
Contributor Author

Reproduced in v8.3.7 as well. 😢 I can check further back if needed, but seems like this is already out and about in the wild then.

@olemartinorg
Copy link
Contributor Author

This turned out to be our mistake in app-frontend-react. 🙌 The app we tested here used v8.0.0, and when I upgraded to newer versions (including v8.3.7 as mentioned above), the types got better, not worse. We had in fact initialized our data with empty strings in these cases, so it should be expected that backend stores that for us - not null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/triage
Projects
Status: No status
Development

No branches or pull requests

1 participant