Rewrite of MimeTypeMap to support extensions with multiple mimetypes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e aliases. Example: zip files can be application/zip, application/zip-compressed or application/x-zip-compressed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Kudos, SonarCloud Quality Gate passed! |
|
I removed the mimetype -> extension method as it was unused in our code and couldn't find any usage of it in altinn.studio. Either way it would potentially make the wrong assumption as .xsd and .xml both have mimetype text/xml for example |
tjololo
added
the
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some file extensions can be represented by multiple mimetypes
Example: zip files can be application/zip, application/zip-compressed or application/x-zip-compressed
There are still some missing mappings between extension and mimetypes, but I propose to fix them in a separate PR to make the changes more visible while reviewing
Related Issue(s)
Fixes #295
Verification
Documentation