Feat/service task #745

bjorntore · 2024-09-04T06:52:23Z

Implementing basic support for service task in bpmn.

Moving PDF and eFormidling into service tasks, but also keep legacy implementations and old way of configuring for backwards compatibility for now.

Description

IServiceTask inherits from IProcessTask and behaves in the same way in most cases, except it also has a method called Execute which must be implemented.
The execute method is called in ProcessNext, right next to where we call user action handlers.

    <bpmn:task id="Task_1" name="Utfylling">
      <bpmn:incoming>SequenceFlow_1n56yn5</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_1oot28q</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>data</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:task>
    <bpmn:serviceTask id="Task_2" name="PDF">
        <bpmn:incoming>SequenceFlow_1oot28q</bpmn:incoming>
        <bpmn:outgoing>SequenceFlow_4ooasd</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>pdf</altinn:taskType>
          <altinn:pdfConfig>
            <altinn:filename>some.text.resource.binding</altinn:filename>
            <altinn:tasksToIncludeInPdf>
              <altinn:task>Task_1</altinn:task>
            </altinn:tasksToIncludeInPdf>
          </altinn:pdfConfig>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>
    <bpmn:serviceTask id="Task_3" name="eFormidling">
      <bpmn:incoming>SequenceFlow_4ooasd</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_5assd2s</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>eFormidling</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>

Related Issue(s)

Support servicetask in application process #368

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)
All tests run green

Documentation

User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

… in process next.

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/EFormidling/EFormidlingServiceTaskTests.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/Pdf/PdfServiceTaskTests.cs

# Conflicts: # src/Altinn.App.Core/Features/Telemetry/Telemetry.cs # src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

sonarcloud · 2024-09-04T08:34:11Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

+                catch (Exception ex)
+                {
+                    serviceTaskActivity?.Errored(ex);
+
+                    var result = new ProcessChangeResult()
+                    {
+                        Success = false,
+                        ErrorMessage = $"Server action {altinnTaskType} failed!",
+                        ErrorType = ProcessErrorType.Internal
+                    };
+                    activity?.SetProcessChangeResult(result);
+                    return result;
+                }


martinothamar

API and stuff LGTM. We discussed

Validation error for trying to invoke actions when current task is a service task
Clear/simple migration story (both old and new apps work) - can we just not run the legacy tasks if a PDF service task refers to the current task for example
Service tasks failing should probably not have 500 status code for the user/client?
Talk to frontenders and Studio team on how the task should be configured

…Add failing test for rejecting PDF service task.

…t for the current task. Done in order to be able to evaluate expressions in gateway while current task is a service task with no layout-set.

…ayout-set for the current task. Done in order to be able to evaluate expressions in gateway while current task is a service task with no layout-set." This reverts commit ef36453.

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

ivarne · 2024-10-09T20:06:45Z

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

-        _pdfService.VerifyNoOtherCalls();
-        _appModel.VerifyNoOtherCalls();
-    }
+        Mock<ILogger<PdfServiceTask>> loggerMock = new();


See https://github.com/Altinn/app-lib-dotnet/blob/feat/multi-data-model-with-validation/test/Altinn.App.Common.Tests/FakeLoggerXunit.cs from #730

Any benefit to using it in this test?

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

…bled in appsettings.json.

# Conflicts: # src/Altinn.App.Core/Internal/Process/ProcessEngine.cs # test/Altinn.App.Api.Tests/Mocks/DataClientMock.cs # test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineTest.cs

sonarcloud · 2024-10-23T06:46:26Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

# Conflicts: # src/Altinn.App.Core/Features/Validation/Default/DefaultTaskValidator.cs # src/Altinn.App.Core/Internal/Process/ProcessEngine.cs # test/Altinn.App.Api.Tests/Altinn.App.Api.Tests.csproj # test/Altinn.App.Core.Tests/Internal/Process/EventHandlers/ProcessTask/EndTaskEventHandlerTests.cs # test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineTest.cs # test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

sonarcloud · 2024-11-25T07:18:51Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bjorntore added 6 commits August 20, 2024 11:21

Pdf and eFormidling as service tasks.

bc7ca62

Rewrite to execute service task in the same way we execute user tasks…

b091935

… in process next.

Integration tests.

83c2d60

Unit test service tasks.

91a07b0

More integration tests.

361cb49

Merge branch 'main' into feat/pdf-service-task

1280a68

github-advanced-security bot found potential problems Sep 4, 2024

View reviewed changes

bjorntore added 5 commits September 4, 2024 09:31

Fix bug in ProcessReader and fix config of pdf service task.

dfcdec1

Move private method below public

d3aae39

Merge branch 'main' into feat/pdf-service-task

3bdae1b

# Conflicts: # src/Altinn.App.Core/Features/Telemetry/Telemetry.cs # src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

Fix merge error

73bbe7e

Various code smells.

3816556

bjorntore added 2 commits September 30, 2024 07:28

Merge branch 'main' into feat/pdf-service-task

9288d86

telemetry

6aacedf

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

martinothamar approved these changes Oct 2, 2024

View reviewed changes

bjorntore force-pushed the feat/pdf-service-task branch from 7584f9a to 6aacedf Compare October 9, 2024 06:00

bjorntore added 8 commits October 9, 2024 09:26

Adjust pdf service task validation

7a1ea59

Rename TaskIds to TaskIdsToIncludeInPdf.

0ddf5cd

Cleanup

694ed3f

Cleanup

c0021bf

Don't run service tasks or user actions if action param is 'reject'. …

b959e2b

…Add failing test for rejecting PDF service task.

Return empty LayoutModel from GetLayoutModel if there is no layout-se…

ef36453

…t for the current task. Done in order to be able to evaluate expressions in gateway while current task is a service task with no layout-set.

Revert "Return empty LayoutModel from GetLayoutModel if there is no l…

bd68b56

…ayout-set for the current task. Done in order to be able to evaluate expressions in gateway while current task is a service task with no layout-set." This reverts commit ef36453.

Merge branch 'main' into feat/pdf-service-task

a5748a2

ivarne reviewed Oct 9, 2024

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs Outdated Show resolved Hide resolved

ivarne reviewed Oct 9, 2024

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs Outdated Show resolved Hide resolved

ivarne reviewed Oct 9, 2024

View reviewed changes

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs Outdated Show resolved Hide resolved

bjorntore added 13 commits October 14, 2024 08:09

Remove extra {}

a6cd0ba

Adjust warning in EFormidlingServiceTask about eformidling being disa…

30759e2

…bled in appsettings.json.

Adjust mocking for PdfServiceTaskTests.

1b88766

Adjust mocking in EFormidlingServiceTaskTests.

89f1dca

Merge branch 'main' into feat/pdf-service-task

98749bb

# Conflicts: # src/Altinn.App.Core/Internal/Process/ProcessEngine.cs # test/Altinn.App.Api.Tests/Mocks/DataClientMock.cs # test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineTest.cs

Merge branch 'main' into feat/pdf-service-task

0a7b8a6

Mock telemetry in ProcessClientMock.

398b6ce

Merge branch 'main' into feat/pdf-service-task

6c959a6

Re-add tests for PdfServiceTaskLegacyTests that disappeared by accident.

5eb399a

Only mock process client in EFormidlingSeviceTaskTests.

6ea5059

Use nameof in service task test model.

76c80cc

Use TrueForAll instead of All. Sonarcloud.

af075f4

Merge branch 'main' into feat/pdf-service-task

804161b

bjorntore mentioned this pull request Oct 23, 2024

Service task support in user interface Altinn/app-frontend-react#2349

Open

6 tasks

Merge branch 'main' into feat/pdf-service-task

5559a1f

bjorntore added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/service task #745

Feat/service task #745

bjorntore commented Sep 4, 2024

sonarcloud bot commented Sep 4, 2024

martinothamar left a comment

ivarne Oct 9, 2024

bjorntore Oct 21, 2024

sonarcloud bot commented Oct 23, 2024

sonarcloud bot commented Nov 25, 2024

Feat/service task #745

Are you sure you want to change the base?

Feat/service task #745

Conversation

bjorntore commented Sep 4, 2024

Description

Related Issue(s)

Verification

Documentation

sonarcloud bot commented Sep 4, 2024

Quality Gate passed

martinothamar left a comment

Choose a reason for hiding this comment

ivarne Oct 9, 2024

Choose a reason for hiding this comment

bjorntore Oct 21, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Oct 23, 2024

Quality Gate passed

sonarcloud bot commented Nov 25, 2024

Quality Gate passed