Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extension methods instead of properties for convenience methods on IInstantanceDataAccessor #907

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Use extension methods instead of properties for convenience methods on IInstantanceDataAccessor #907

merged 2 commits into from
Nov 22, 2024

Commits on Nov 22, 2024

  1. Use extension methods instead of properties for convenience methods o… 

    …n IInstantanceDataAccessor

Interface properties with default implementations has a few drawbacks.

* They need to be mocked individually, because Moq does not use the default implementation
* They typically only serve as a starting point for futher filtering using linq. An extension methdod takes an argument (task/dataType) which is easier to understand than a linq .Where filter.

Another benefit is that we encapsulate appMetadata so that user code has even less reason to deal with dataType
    @ivarne
    ivarne committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9237661 View commit details
    Browse the repository at this point in the history

  2. Fix sonar issues and improve test coverage

    @ivarne
    ivarne committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7a57d06 View commit details
    Browse the repository at this point in the history